From owner-freebsd-arch@FreeBSD.ORG Tue Jan 20 07:28:59 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 47BAE2D9; Tue, 20 Jan 2015 07:28:59 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F21DBE6; Tue, 20 Jan 2015 07:28:58 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 4F3A11FE023; Tue, 20 Jan 2015 08:28:56 +0100 (CET) Message-ID: <54BE03EB.2070604@selasky.org> Date: Tue, 20 Jan 2015 08:29:47 +0100 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Jason Wolfe , John Baldwin Subject: Re: [RFC] kern/kern_timeout.c rewrite in progress References: <54A1B38C.1000709@selasky.org> <20150101005613.4f788b0c@nonamehost.local> <54A49CA5.2060801@selasky.org> <54A4A002.8010802@selasky.org> <54A53F4F.2000003@selasky.org> <54A92ED1.2070906@selasky.org> <54A9A71E.70609@selasky.org> <54B29A49.3080600@selasky.org> <54B67DA7.3070106@selasky.org> <54B7DECF.8070209@selasky.org> <54BADFB3.3030405@selasky.org> In-Reply-To: <54BADFB3.3030405@selasky.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Adrian Chadd , FreeBSD Current , Sean Bruno , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 07:28:59 -0000 On 01/17/15 23:18, Hans Petter Selasky wrote: > On 01/17/15 20:11, Jason Wolfe wrote: >> >> HPS, >> >> Just to give a quick status update, this patch has most certainly >> resolved our spin lock held too long panics on stable/10. >> >> Thank you to JHB for spending some time digging into the issue and >> leading us to td_slpcallout as the culprit, and HPS for your rewrite. >> I had heard rumors of other being affected by similar issues, so this >> seems like a fine candidate for an MFC if possible. >> >> Jason >> > > Hi Jason, > > I'm glad to hear that my patch has resolved your issue and I'm happy we > now have a more stable system. > > It was actually a co-worker at work which wrote some bad code which I > started debugging which then lead me to look at the callout subsystem. > One bug kills the other ;-) > > I'm planning a MFC to 10-stable - yes, and will possibly add the > _callout_stop_safe() function to not break binary compatibility with > existing drivers as part of the MFC. > > --HPS Hi, Here is a followup patch for the TCP stack like I mentioned in the beginning of the work done on the callout subsystem: https://reviews.freebsd.org/D1563 If someone has a setup for massive TCP testing please give it a spin. Thank you! --HPS