Date: Sat, 2 Jul 2022 16:46:42 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Neel Chauhan <nc@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6a6c45fae02b - main - textproc/yelp-xsl: use 'gnome' dir not 'gnome3' Message-ID: <20220702144642.f6t42og6hrpllm6i@aching.in.mat.cc> In-Reply-To: <202207011836.261Ia2Ru056302@gitrepo.freebsd.org> References: <202207011836.261Ia2Ru056302@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--3ynhudqlc3bo6al4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 01, 2022 at 06:36:02PM +0000, Neel Chauhan wrote: > The branch main has been updated by nc: >=20 > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D6a6c45fae02b647bece42cd9= 613e2fe42560b7ed >=20 > commit 6a6c45fae02b647bece42cd9613e2fe42560b7ed > Author: Neel Chauhan <nc@FreeBSD.org> > AuthorDate: 2022-07-01 18:34:49 +0000 > Commit: Neel Chauhan <nc@FreeBSD.org> > CommitDate: 2022-07-01 18:34:49 +0000 >=20 > textproc/yelp-xsl: use 'gnome' dir not 'gnome3' This (and all the commits like this one, which should probably have been done as one commit anyway) really need to explain WHY you do things. Really Neel, many people have asked you to explain why you do things in commit messages. Right now, what it does is force everyone to re-download all those distfiles, and nothing is gained by anyone. Nobody cares the directory where the distfiles are stored, one can probably guess than if the directory is "gnome" or "gnome3" it is related to gnome. > --- > textproc/yelp-xsl/Makefile | 2 +- > textproc/yelp-xsl/distinfo | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/textproc/yelp-xsl/Makefile b/textproc/yelp-xsl/Makefile > index 8a64322a30a8..18effb687589 100644 > --- a/textproc/yelp-xsl/Makefile > +++ b/textproc/yelp-xsl/Makefile > @@ -4,7 +4,7 @@ PORTNAME=3D yelp-xsl > DISTVERSION=3D 42.0 > CATEGORIES=3D textproc gnome > MASTER_SITES=3D GNOME/sources/${PORTNAME}/${PORTVERSION:C/^([0-9]+)\..*/= \1/} > -DIST_SUBDIR=3D gnome3 > +DIST_SUBDIR=3D gnome > =20 > MAINTAINER=3D gnome@FreeBSD.org > COMMENT=3D DocBook XSLT stylesheets for yelp > diff --git a/textproc/yelp-xsl/distinfo b/textproc/yelp-xsl/distinfo > index c299ca1bea99..38a3fd4f0234 100644 > --- a/textproc/yelp-xsl/distinfo > +++ b/textproc/yelp-xsl/distinfo > @@ -1,3 +1,3 @@ > -TIMESTAMP =3D 1656533012 > -SHA256 (gnome3/yelp-xsl-42.0.tar.xz) =3D 29b273cc0bd16efb6e983443803f1e9= fdc03511e5c4ff6348fd30a604d4dc846 > -SIZE (gnome3/yelp-xsl-42.0.tar.xz) =3D 663824 > +TIMESTAMP =3D 1656700465 > +SHA256 (gnome/yelp-xsl-42.0.tar.xz) =3D 29b273cc0bd16efb6e983443803f1e9f= dc03511e5c4ff6348fd30a604d4dc846 > +SIZE (gnome/yelp-xsl-42.0.tar.xz) =3D 663824 Side note, the TIMESTAMP should not have changed as the distfile itself has not. --=20 Mathieu Arnold --3ynhudqlc3bo6al4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEFD4jMKwz5Ud8Ywu3ecmT/A9inX0FAmLAWkdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDE0 M0UyMzMwQUMzM0U1NDc3QzYzMEJCNzc5Qzk5M0ZDMEY2MjlEN0QACgkQecmT/A9i nX2J+gf9E4tgGayMa08GaYPb3nHt0xi1cIj5GppP/vIksZD/bnJYzUCwCFkTI2UJ KnRiBuwtsxKyz6bmwMZrvSljJL4RtgGn1FUQ8kQHdUy3IWi5KOAv8vnHV5E+91hx TGXzhKlXpwBzcRFxUXa1RkAXWts74XbC3HT66oGUJ17UAVDHdQcuJk+fNX3cYSTJ 5vTka0wFw9wTrmPHXdm/FT8JXjTTwLQanEXtZA5LMosGtfaxY2G5NQD6st4mOp17 oUEZvbRQ1QemKkiQrOwyonD2qianMBgxCeZMBSh/s/mEoDAH9ajEGeJDb2jyRxV2 f2a5i7D6NWv9rvMlDKKHM0rM/c4vTg== =MgB2 -----END PGP SIGNATURE----- --3ynhudqlc3bo6al4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220702144642.f6t42og6hrpllm6i>