From owner-svn-src-all@freebsd.org Fri Sep 27 00:18:11 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E5C40F026E; Fri, 27 Sep 2019 00:18:11 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46fXSg4jX9z48Fx; Fri, 27 Sep 2019 00:18:11 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-qt1-x844.google.com with SMTP id m15so5175644qtq.2; Thu, 26 Sep 2019 17:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MHkAUbGlQ4HQNgR4BsCjPWN42d91GT6bD0iPbrU9DRE=; b=AZxS9oLkFKmN/9+rmhkDql0za/Q2lvQkB5H8la/g9jrslEuOHjylUoULg1cbMRu7xd 3uRMKmYML0ps3i4HiUvs7oCdz4z44mR3RdYObUeIdzx4wKBetNURC6Goqf/mffGhiZXo BhzbFOvgtjppl8V3lMgTQVjarFclcN9vkK40UourwYJ49Zev/H6XI8zWJUYRDMG9nmUf o8cZASME12hf4MOUPUQMTk/ntK71ykMiVOwXVco9V9Y3E05pb0P69IPOO5efajNIjzlO 5e36i18S45NNWQdO7PeMNgMGYhm2YCPBJ5+2p9lA3qQlEvOktD75d56GG8a6O6vwYh21 Z8sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MHkAUbGlQ4HQNgR4BsCjPWN42d91GT6bD0iPbrU9DRE=; b=fwsGJakbqsZx9idBD4tFi288D5cqasPCZmRqqVrLxEtoEnvAivsSEu4FRk6JEGWa5T btGv4YoyOZbLRmWU1QTD76PQ8lcx7SsNNLJm++kQ8mp7yF56hP1gy7J3Z/urDB0xLzPJ A9wzuwbJCR0jo0w+vV/f9o9SGTGZXpiqR7LaaWPcuWAK7a3Y+jbjfSHL8uE/ngjsbjTP dpLCAKltG1n7tKGLPycoUD37fz9iCU5eF9ITrE/6afCJDWF0ymrwmVOFVxgNioLenvbg 4tPpMOTB31cSs8kzz/5CqUbMjVWFw1f8mVM/VL/tSPhSdBwoAS/7kYH8fw5SM8AUhzzx liag== X-Gm-Message-State: APjAAAWlTjw3vLJCT3g20F54I1L1DqZJJLIUF9DkrkZBJfllL21uDwgK luYRjdQS6hSxnhzUkllRpV7HkT6GgdWbPN/qXv6uHN4v X-Google-Smtp-Source: APXvYqyxyd4ApyTvHFDTmAVrfjWxbYkMQGaNLi37AyCPfNb1PUqNDKsJTi1kvwXRG4SoWqhTBO5RuC0rr/ofG9rn8vw= X-Received: by 2002:ac8:845:: with SMTP id x5mr7194679qth.42.1569543488955; Thu, 26 Sep 2019 17:18:08 -0700 (PDT) MIME-Version: 1.0 References: <201909262112.x8QLCl9o061816@repo.freebsd.org> In-Reply-To: <201909262112.x8QLCl9o061816@repo.freebsd.org> From: Ryan Stone Date: Thu, 26 Sep 2019 20:17:57 -0400 Message-ID: Subject: Re: svn commit: r352778 - in head/sys: conf sys To: Gleb Smirnoff Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46fXSg4jX9z48Fx X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Sep 2019 00:18:12 -0000 Is this enough? Won't out-of-tree modules get compiled without EPOCH_TRACE set? If such a module is loaded on a kernel with EPOCH_TRACE set then the module will call epoch_enter_preempt() with a epoch_tracker that is too small and have its stack corrupted, won't it? On Thu, Sep 26, 2019 at 5:12 PM Gleb Smirnoff wrote: > > Author: glebius > Date: Thu Sep 26 21:12:47 2019 > New Revision: 352778 > URL: https://svnweb.freebsd.org/changeset/base/352778 > > Log: > Move EPOCH_TRACE to opt_global.h, so that any external modules that > use epoch don't need Makefile tweaks. > > The downside is that any developer who wants EPOCH_TRACE needs to > rebuild kernel in full, but that's fine. > > Reviewed by: imp > > Modified: > head/sys/conf/options > head/sys/sys/epoch.h > > Modified: head/sys/conf/options > ============================================================================== > --- head/sys/conf/options Thu Sep 26 21:06:55 2019 (r352777) > +++ head/sys/conf/options Thu Sep 26 21:12:47 2019 (r352778) > @@ -712,7 +712,7 @@ WITNESS_SKIPSPIN opt_witness.h > WITNESS_COUNT opt_witness.h > OPENSOLARIS_WITNESS opt_global.h > > -EPOCH_TRACE opt_epoch.h > +EPOCH_TRACE opt_global.h > > # options for ACPI support > ACPI_DEBUG opt_acpi.h > > Modified: head/sys/sys/epoch.h > ============================================================================== > --- head/sys/sys/epoch.h Thu Sep 26 21:06:55 2019 (r352777) > +++ head/sys/sys/epoch.h Thu Sep 26 21:12:47 2019 (r352778) > @@ -41,8 +41,6 @@ typedef struct epoch_context *epoch_context_t; > #include > #include > > -#include "opt_epoch.h" > - > struct epoch; > typedef struct epoch *epoch_t; >