Date: Thu, 03 May 2012 18:02:51 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Marius Strobl <marius@alchemy.franken.de>, Gavin Mu <gavin.mu@gmail.com>, John Baldwin <jhb@FreeBSD.org> Cc: freebsd-fs@FreeBSD.org, freebsd-hackers@FreeBSD.org Subject: Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool Message-ID: <4FA29E1B.7040005@FreeBSD.org> In-Reply-To: <20120501202128.GD18650@alchemy.franken.de> References: <4F8999D2.1080902@FreeBSD.org> <20120422212102.GA66855@alchemy.franken.de> <4F9A6180.8090500@FreeBSD.org> <20120429164623.GG68446@alchemy.franken.de> <4F9E3971.7090405@FreeBSD.org> <20120501202128.GD18650@alchemy.franken.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Here's the latest version of the patches: http://people.freebsd.org/~avg/zfsboot.patches.4.diff John, the first of the patches implements the approach that we previously discussed. All arguments are passed starting at a fixed offset that should provide enough space for extending argument list. The first of the extended arguments should be a size of the arguments (including the size field). Then it's easy to write something like: struct xargs { uint32_t size; ... }; ... struct xargs xargs; xargs.size = sizeof(xargs); ... __exec(..., xargs); Marius, Gavin, patch 1f94d9a is my attempt of adapting your sparc64 ZFS code to my larger changes in patch ae5a9c6. I have the patches separate to facilitate the review. They should be committed together. I have only compile-tested the sparc64/ofw part, so it could have some grave bugs or omissions. Could you please review and/or test this patch? I will greatly appreciate any discussion, suggestions, help. I again invite everyone else to take part in the review and testing. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FA29E1B.7040005>