From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Feb 27 12:20:08 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 08367106564A for ; Mon, 27 Feb 2012 12:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D95A48FC15 for ; Mon, 27 Feb 2012 12:20:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q1RCK7FY061645 for ; Mon, 27 Feb 2012 12:20:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q1RCK74p061644; Mon, 27 Feb 2012 12:20:07 GMT (envelope-from gnats) Resent-Date: Mon, 27 Feb 2012 12:20:07 GMT Resent-Message-Id: <201202271220.q1RCK74p061644@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kuan-Chung Chiu Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 353411065670 for ; Mon, 27 Feb 2012 12:14:58 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 0B7EF8FC12 for ; Mon, 27 Feb 2012 12:14:58 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q1RCEvw6065177 for ; Mon, 27 Feb 2012 12:14:57 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q1RCEvBp065176; Mon, 27 Feb 2012 12:14:57 GMT (envelope-from nobody) Message-Id: <201202271214.q1RCEvBp065176@red.freebsd.org> Date: Mon, 27 Feb 2012 12:14:57 GMT From: Kuan-Chung Chiu To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/165503: [patch] fix crash for editors/madedit X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2012 12:20:08 -0000 >Number: 165503 >Category: ports >Synopsis: [patch] fix crash for editors/madedit >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Feb 27 12:20:07 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Kuan-Chung Chiu >Release: 10-CURRENT >Organization: N/A >Environment: FreeBSD Bohemia.twbbs.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r231997: Thu Feb 23 01:35:20 CST 2012 root@Bohemia.twbbs.org:/usr/obj/usr/src/sys/BOHEMIA amd64 >Description: madedit crash when opening multiple files in an instance. >How-To-Repeat: >Fix: apply https://github.com/dol/madedit/commit/80b09fb0b0b457cd2a94c46c1185db22f6d302be Patch attached with submission follows: diff -ruN madedit.orig/Makefile madedit/Makefile --- madedit.orig/Makefile 2012-02-27 20:08:23.000000000 +0800 +++ madedit/Makefile 2012-02-27 20:08:32.000000000 +0800 @@ -7,7 +7,7 @@ PORTNAME= madedit PORTVERSION= 0.2.9 -PORTREVISION= 5 +PORTREVISION= 6 CATEGORIES= editors MASTER_SITES= SF/${PORTNAME}/MadEdit/MadEdit-${PORTVERSION} diff -ruN madedit.orig/files/patch-src-MadEdit-MadEdit.cpp madedit/files/patch-src-MadEdit-MadEdit.cpp --- madedit.orig/files/patch-src-MadEdit-MadEdit.cpp 1970-01-01 08:00:00.000000000 +0800 +++ madedit/files/patch-src-MadEdit-MadEdit.cpp 2012-02-27 20:08:06.000000000 +0800 @@ -0,0 +1,24 @@ +--- src/MadEdit/MadEdit.cpp.orig 2012-02-27 20:06:18.000000000 +0800 ++++ src/MadEdit/MadEdit.cpp 2012-02-27 20:07:26.000000000 +0800 +@@ -9739,7 +9739,9 @@ + { + if(m_EditMode!=emHexMode) + { +- memdc.SelectObject(*m_ClientBitmap); ++ if(m_ClientBitmap!=NULL) { ++ memdc.SelectObject(*m_ClientBitmap); ++ } + memdc.SetFont(*m_TextFont); + + // calculate rows to paint +@@ -9917,7 +9919,9 @@ + + if(bPaintMark==false) + { +- markdc.SelectObject(*m_MarkBitmap); ++ if(m_MarkBitmap!=NULL) { ++ markdc.SelectObject(*m_MarkBitmap); ++ } + markdc.Blit(0,0,m_ClientWidth,m_ClientHeight, &memdc, 0, 0); + bPaintMark=true; + } >Release-Note: >Audit-Trail: >Unformatted: