From owner-svn-src-head@freebsd.org Mon Jan 14 20:13:44 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 097591485F16; Mon, 14 Jan 2019 20:13:44 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E908073B69; Mon, 14 Jan 2019 20:13:42 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id j8c8gnkSVnBo4j8c9gMkBX; Mon, 14 Jan 2019 13:13:41 -0700 X-Authority-Analysis: v=2.3 cv=J8fUEzvS c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=3JhidrIBZZsA:10 a=iKhvJSA4AAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=PBJgjM2NpsWgmWMOLkQA:9 a=CjuIK1q_8ugA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id D2F816FC; Mon, 14 Jan 2019 12:13:48 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x0EKDd6B004744; Mon, 14 Jan 2019 12:13:39 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x0EKDdsA004741; Mon, 14 Jan 2019 12:13:39 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201901142013.x0EKDdsA004741@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: rgrimes@freebsd.org cc: Takahashi Yoshihiro , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343011 - in head/kerberos5: lib/libasn1 lib/libgssapi_krb5 lib/libhdb lib/libheimntlm lib/libhx509 lib/libkadm5clnt lib/libkadm5srv lib/libkdc lib/libkrb5 lib/libwind libexec/digest-se... In-Reply-To: Message from "Rodney W. Grimes" of "Mon, 14 Jan 2019 08:17:58 -0800." <201901141617.x0EGHwqQ035748@pdx.rh.CN85.dnsmgr.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 14 Jan 2019 12:13:39 -0800 X-CMAE-Envelope: MS4wfJGQiRdOE4ZZxesD6HfcudFKMnr+Jmh93UaXE6Ktcu8AB6ZaLFI23ad3l0DNWUNgcdX++y5tSaJUyZRCLGHa4O6YrRskvj56D2AC1uc+iBVnv+WqCt+j I0fSClMXtnO9xOt746xibAMhgHjPRP1ZPpYSDGt9ei8ytoT7twmhPGM4b6y1gYn8l0uxp0BX0ga0NwfSwIlZ4pWpOG/FSZRMWCwUxCwKf6TYJiTkurv/8uqr kexMthw+vjUwQZ1+SgkIL0xm90SafVLtMebbCX8JkQiaQsGacSYjdOOP//V0IvLme/25AvjoWXYYFemvZXISRA== X-Rspamd-Queue-Id: E908073B69 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.85 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; HAS_XAW(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; LONG_SUBJ(1.52)[203]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.94)[-0.938,0]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_LOW(-0.10)[137.136.59.64.list.dnswl.org : 127.0.5.1]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCVD_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-1.73)[ip: (-4.36), ipnet: 64.59.128.0/20(-2.36), asn: 6327(-1.82), country: CA(-0.09)]; R_SPF_NA(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 20:13:44 -0000 In message <201901141617.x0EGHwqQ035748@pdx.rh.CN85.dnsmgr.net>, "Rodney W. Gri mes" writes: > > Author: nyan > > Date: Mon Jan 14 06:34:54 2019 > > New Revision: 343011 > > URL: https://svnweb.freebsd.org/changeset/base/343011 > > > > Log: > > Use ${SRCTOP}/contrib/com_err/com_err.h instead of the installed com_err. > h. > > This fixes build when com_err.h is not installed. > > Isn't this the general state of affairs for almost all > of the source tree? I would rather see this solved > in a general way, rather than sprinkly all this > -I${SRCTOP} all over in the tree. Agreed however in practice this is fixed when discovered while working on other issues/problems/projects. > > It use to be (and maybe still is) required that you run > cd $DRCTOP && make includes > if you expected new source code to compile. I expect > this has changed, but the just of it should work in > some aspect. This fixes the potential bug of requiring a header file to be installed. I suspect this to be an oversight at the time. Good that it's fixed now. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.