From nobody Sun May 31 00:11:38 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gScvw5L6Dz6gwPb for ; Sun, 31 May 2026 00:11:40 +0000 (UTC) (envelope-from vexeduxr@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gScvw4G84z3dyX for ; Sun, 31 May 2026 00:11:40 +0000 (UTC) (envelope-from vexeduxr@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780186300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m2W7CY8fK+tGExhZTwemvCjiydMfOmH/1bjK4Xi1X4c=; b=U3wmx64yMJ4AQN0/hN4qK3Jq4i7b9CNRmptugIbNkDTKMTHiM1UCjQBILAkRbYAY3D3ZLC piW3v2tVfMNlMJ49trofg0I14z450vepKsaPFMSUZDwmuHZscaWfhGI+Ed2tO/B3Dtv9AD shIVASiZKnvNL8uh4Di8CrPbg5EdhH9YYwWW+T/3PYvghhDor+bi2Pxg9Kx5LflzslMhzN 2RkufrW6JqjwQn+nJPbCC2mYI0Eu6hdcsExYhqUdRti8gDnfUK5cv/5JysU/UeiifENc2N OcX1/4R6gvFT82Ir2mduFlX3shy5mpGB9TT/iFzJ5ES0IxgSEqedFgZWIzxgIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780186300; a=rsa-sha256; cv=none; b=UbWkKFNkFtHhKUys124ym4tZ7ljH7FkAjV1jVt0bOamQycLRsSgOZe6IO0lKP34BCjp6JV OYO7I0MMchqOqEFrJGERHOqaWpVIXh5WyTbjUsVUXPeiGnNHdbVYXjUgoiPZoR/eWPtk1u PkL2WhB2ZU8OuHCxdxp7jOGwpvoVnspBAfZJbfxrfXdfxPHKsXKNDKWf03h90qCMHiv0wx GXUep+O/WGCdJIanApVtY3DmSV09zmu5KzGzzFQv9CVq6y8gIL5OCa3FzWzIN5iQGj1xHh o/m82zw7dD9V/sVNtODgktB93yZ81gercwGb9mSm0cHPy6ggZykZ/HLtDSaitg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780186300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m2W7CY8fK+tGExhZTwemvCjiydMfOmH/1bjK4Xi1X4c=; b=aSysqbFwAGJo8BysEuGTclm0vIWd4uwWEvaEZJvgOVQjq4I2J3mqqOCnD1D3m9pl8fu1Gq 25urnuq4uoJ14OAzhRJeUEnXHkzUn+z8wLTtNJm46JXIE+DyNgsxHdac/3N2u/1HplmbQ0 ugwZzVgf9XoxUlZ0pe75MWyPRLoZNtzKSdDEcw9FiKPWuYXGA1XE28gxW7pYqUIrwHc4tV acH5h4tMBavQ7c7kPZK0T+Gg9UR1vLef5f0FBHz+7F3coZpA19bn7td0VeMafVRrey2hi3 giceMO6uGNeTrM3iVZSPt+D+/LyBH9qzJt9TjL8VXHNSar7su++5By89jKaldw== Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: vexeduxr) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gScvw3GCszFwP for ; Sun, 31 May 2026 00:11:40 +0000 (UTC) (envelope-from vexeduxr@freebsd.org) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-36d98b9aa9aso152811a91.3 for ; Sat, 30 May 2026 17:11:40 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ9s9WuW3DGbM2Qe8qigeDCopT4jWq5r5urwPfjGbXgYlC4oVJSi1qruS/LcgvSUzEORGoSt9s5shAgbTg++7cmVeEWbfg==@freebsd.org X-Gm-Message-State: AOJu0Yy5KOD57FGsPalZVK9N+tzuE8ulXFqgO4lcSL7PyL9opltZuV4d Q0mqEHxr20QPfcY7q5oMEJwc4Lg8AJ7W9ATF/LE3VOjmvBng6I6LQwMsYrE5Y4krO8XsC/ICJhu sGH/AyKHYMqIWtkl7EROMdWA8Dpjsz68= X-Received: by 2002:a17:90b:3e8c:b0:36a:f623:83a4 with SMTP id 98e67ed59e1d1-36c684afc9fmr5278768a91.26.1780186299344; Sat, 30 May 2026 17:11:39 -0700 (PDT) Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sat, 30 May 2026 17:11:38 -0700 Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sat, 30 May 2026 17:11:38 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 From: Ahmad Khalifa X-Mailer: aerc 0.21.0 References: <6a1a4f38.32b9d.5eb5f95e@gitrepo.freebsd.org> <20260530190827.15ba6ffa@thor.sb211.local> In-Reply-To: Date: Sat, 30 May 2026 17:11:38 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AVHnY4I-oK1lzNo4xfsnm40QuavvCzCUHrnUWUJhYdWHvqMXxC_zaTL5rhpq5IU Message-ID: Subject: Re: git: 2fa4bdd7f9e9 - main - edk2: enable static asserts for *INT64 alignment To: Kevin Bowling Cc: A FreeBSD User , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun May 31, 2026 at 1:54 AM +0300, Kevin Bowling wrote: > On Sat, May 30, 2026 at 2:50=E2=80=AFPM Ahmad Khalifa wrote: >> >> On Sat May 30, 2026 at 8:09 PM +0300, A FreeBSD User wrote: >> > Am Tage des Herren Sat, 30 May 2026 02:45:12 +0000 >> > Ahmad Khalifa schrieb: >> > >> >> The branch main has been updated by vexeduxr: >> >> >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D2fa4bdd7f9e99698a6652d= b405c3165fdcd41c1d >> >> >> >> commit 2fa4bdd7f9e99698a6652db405c3165fdcd41c1d >> >> Author: Ahmad Khalifa >> >> AuthorDate: 2026-05-30 02:40:58 +0000 >> >> Commit: Ahmad Khalifa >> >> CommitDate: 2026-05-30 02:40:58 +0000 >> >> >> >> edk2: enable static asserts for *INT64 alignment >> >> >> >> The ia32 loader is now built with -malign-double, so these should= pass. >> >> >> >> Differential Revision: https://reviews.freebsd.org/D55386 >> >> --- >> >> sys/contrib/edk2/Include/Base.h | 2 -- >> >> 1 file changed, 2 deletions(-) >> >> >> >> diff --git a/sys/contrib/edk2/Include/Base.h b/sys/contrib/edk2/Inclu= de/Base.h >> >> index 3ae798db8429..d3342c9a6ca2 100644 >> >> --- a/sys/contrib/edk2/Include/Base.h >> >> +++ b/sys/contrib/edk2/Include/Base.h >> >> @@ -841,10 +841,8 @@ STATIC_ASSERT (ALIGNOF (INT16) =3D=3D sizeof (= INT16), "Alignment of INT16 >> >> does not STATIC_ASSERT (ALIGNOF (UINT16) =3D=3D sizeof (UINT16), "Al= ignment of UINT16 does not >> >> meet UEFI Specification Data Type requirements"); STATIC_ASSERT (ALIG= NOF (INT32) =3D=3D sizeof >> >> (INT32), "Alignment of INT32 does not meet UEFI Specification Data Ty= pe requirements"); >> >> STATIC_ASSERT (ALIGNOF (UINT32) =3D=3D sizeof (UINT32), "Alignment o= f UINT32 does not meet UEFI >> >> Specification Data Type requirements"); -#ifndef _STANDALONE STATIC_A= SSERT (ALIGNOF (INT64) >> >> =3D=3D sizeof (INT64), "Alignment of INT64 does not meet UEFI Specif= ication Data Type >> >> requirements"); STATIC_ASSERT (ALIGNOF (UINT64) =3D=3D sizeof (UINT6= 4), "Alignment of UINT64 >> >> does not meet UEFI Specification Data Type requirements"); -#endif ST= ATIC_ASSERT (ALIGNOF >> >> (CHAR8) =3D=3D sizeof (CHAR8), "Alignment of CHAR8 does not meet UE= FI Specification Data Type >> >> requirements"); STATIC_ASSERT (ALIGNOF (CHAR16) =3D=3D sizeof (CHAR1= 6), "Alignment of CHAR16 >> >> does not meet UEFI Specification Data Type requirements"); STATIC_ASS= ERT (ALIGNOF (INTN) >> >> =3D=3D sizeof (INTN), "Alignment of INTN does not meet UEFI Specifica= tion Data Type >> >> requirements"); >> >> >> > >> > The commit seems to disturb building process and gets rogue with: >> > [...] >> > In file included from /usr/src/sys/contrib/edk2/Include/Uefi/UefiBaseT= ype.h:16: >> > /usr/src/sys/contrib/edk2/Include/Base.h:844:16: error: static asserti= on failed due to >> > requirement '_Alignof(long long) =3D=3D sizeof(long long)': Alignment = of INT64 does not meet UEFI >> > Specification Data Type requirements 844 | STATIC_ASSERT (ALIGNOF (INT= 64) =3D=3D sizeof (INT64), >> > "Alignment of INT64 does not meet UEFI Specification Data Type require= ments"); | >> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/sys/contrib/edk2/Include= /Base.h:778:24: note: >> > expanded from macro 'ALIGNOF' >> >> I can't reproduce with the defaults, do you have any loader related >> build options changed? > > Maybe a transient stale rebuild artifact, I was able to get through it > with -j1 somehow. Hmm, after building this a few times I do run into a race condition where the interpreter isn't done building before loader_ia32.efi. Is that what you ran into? Looks like the SUBDIR entries need to be re-ordered, that's a different issue from the one above though. > >> Also, can you tell which target this failed on? >> >> Thanks. >> >> > >> > >> > Regards >> > oh >>