From owner-svn-src-stable-8@FreeBSD.ORG  Tue Apr 16 17:50:20 2013
Return-Path: <owner-svn-src-stable-8@FreeBSD.ORG>
Delivered-To: svn-src-stable-8@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id E6EF47D0;
 Tue, 16 Apr 2013 17:50:20 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id D95ECB69;
 Tue, 16 Apr 2013 17:50:20 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.6/8.14.6) with ESMTP id r3GHoKP4045225;
 Tue, 16 Apr 2013 17:50:20 GMT (envelope-from dim@svn.freebsd.org)
Received: (from dim@localhost)
 by svn.freebsd.org (8.14.6/8.14.5/Submit) id r3GHoKTR045224;
 Tue, 16 Apr 2013 17:50:20 GMT (envelope-from dim@svn.freebsd.org)
Message-Id: <201304161750.r3GHoKTR045224@svn.freebsd.org>
From: Dimitry Andric <dim@FreeBSD.org>
Date: Tue, 16 Apr 2013 17:50:20 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject: svn commit: r249557 - stable/8/sys/mips/atheros
X-SVN-Group: stable-8
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-stable-8@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for only the 8-stable src tree
 <svn-src-stable-8.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-stable-8>, 
 <mailto:svn-src-stable-8-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-8>
List-Post: <mailto:svn-src-stable-8@freebsd.org>
List-Help: <mailto:svn-src-stable-8-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable-8>, 
 <mailto:svn-src-stable-8-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2013 17:50:21 -0000

Author: dim
Date: Tue Apr 16 17:50:20 2013
New Revision: 249557
URL: http://svnweb.freebsd.org/changeset/base/249557

Log:
  MFC r249449:
  
  Fix undefined behaviour in several gpio_pin_setflags() routines (under
  sys/arm and sys/mips), squelching the clang 3.3 warnings about this.
  
  Noticed by:	tinderbox and many irate spectators
  Submitted by:	Luiz Otavio O Souza <loos.br@gmail.com>
  PR:		kern/177759

Modified:
  stable/8/sys/mips/atheros/ar71xx_gpio.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/mips/   (props changed)

Modified: stable/8/sys/mips/atheros/ar71xx_gpio.c
==============================================================================
--- stable/8/sys/mips/atheros/ar71xx_gpio.c	Tue Apr 16 17:47:13 2013	(r249556)
+++ stable/8/sys/mips/atheros/ar71xx_gpio.c	Tue Apr 16 17:50:20 2013	(r249557)
@@ -225,8 +225,8 @@ ar71xx_gpio_pin_setflags(device_t dev, u
 	if (i >= sc->gpio_npins)
 		return (EINVAL);
 
-	/* Filter out unwanted flags */
-	if ((flags &= sc->gpio_pins[i].gp_caps) != flags)
+	/* Check for unwanted flags. */
+	if ((flags & sc->gpio_pins[i].gp_caps) != flags)
 		return (EINVAL);
 
 	/* Can't mix input/output together */