From owner-freebsd-net@freebsd.org Sat Aug 26 16:55:33 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 68D44DD5CD9 for ; Sat, 26 Aug 2017 16:55:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49AA6712FD for ; Sat, 26 Aug 2017 16:55:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7QGtXhY088154 for ; Sat, 26 Aug 2017 16:55:33 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 221676] arp: invalid json output from libxo when bridge is present Date: Sat, 26 Aug 2017 16:55:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: duncan@splash.fish X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Aug 2017 16:55:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221676 Duncan Paterson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |duncan@splash.fish --- Comment #1 from Duncan Paterson --- Created attachment 185787 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185787&action= =3Dedit Adds the quote directive to xo fields to make sure that strings are quoted = in json output I can reproduce this in general for libxo.=20 The number detecting heuristic it uses allows for C style numeric suffices = (for example 34f, 12d). This allows any strings ending the characters in the set [diouDOUeEfFgG] to be treated as numbers (left unquoted in json). This has = two drawbacks firstly leaving strings such as bridge unquoted because it ends i= n e, secondly it allows numbers with C style suffices to be output unqoted these= are not valid json. for example: { "key": 35f } is invalid. I've added the quote directive to all of the relevant xo_emit calls as per = the documentation on libxo at http://juniper.github.io/libxo/libxo-manual.html. --=20 You are receiving this mail because: You are the assignee for the bug.=