From nobody Thu Jul 9 15:18:46 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gwzBg6SqRz6kN2p for ; Thu, 09 Jul 2026 15:18:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gwzBg5jnKz3NH5 for ; Thu, 09 Jul 2026 15:18:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783610331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gKtgWqEhVxOpaC2tb+cOwTAHmlUbTjS6u8S0dlB7bFc=; b=ah33jWzpKlJ9ualE0NOWJw7EANdmpg5g70Z9nOqZcw3eSYYGSqsUDdvYpVUo1a8b602tTR HvpdQ0aaMLeOUNVOKwjSHuasTj935cSMI3OnvO+/Qktx9Foqxwc9ytmO7H7zzUAkIUo2Nf m5AanFvhr/Rom2qdIl5D0OigmJHb8N45+RoYIhZkAX/OELy9bpbi/L2Oat0QHv6JhQSFlB j8Eq0xyB6WS1T1/KpJJhnuebJ4WeJze9osMIQsG0bgQRZI3sGKRX1RqP117bSK+qlfCvXA lN39pjFMM7DAQLXfmnE6UpnhlTafAE4AVnQTmtZn7vQxhMyrGkQkYDkU8kL7+g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783610331; a=rsa-sha256; cv=none; b=eQaWQZcdqZiRWoiKU07NcShK1Wjc7hNHb6Kq1EgqNM859Pa8ykFqLrAT+YVVWHR2RdHSAX YKunKSr/b/0rniR6zFSB8322G1JF1rYxoJ6BNot9gaHFO0VYaLNV4xJ9mBTZqVz1yt4yCu TXBDE0NGQysRjs37XHTDYoHm2nUEjFiDauS9QVW38UvXQqVAkAaa53ahMAUSGR4m8ZDHWo EQiw7M6eCpw3mTmIr8YgchMfBh4SzLsSBCf+M0OqyoHeRKhlBTqf0BqSTxTq1kVxjnUpfT aCAQjvj0WP/8AtxThupO3wg6U0TCWa8cjwl1FJH9TGlT8wNx8XlCy8kr6FTdrw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783610331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gKtgWqEhVxOpaC2tb+cOwTAHmlUbTjS6u8S0dlB7bFc=; b=yBTlNQ+H2HSmJ+AyP9PdYv2fgV4HHczz3P2oNZ4fXlgU6RE0k2Dz0wBd0Ce+njpPrMmQif 5kfQUGqtuI7Jn6UX4wv2r/2fFqPWlbijMtxdEkEV5wFHMXAGeo3j34kMJ2bAijAO4SFRI5 hHy3i/OSEfHYp03pfhjI9L50yciDo5JNWcmIT3WavNT5bRTh0mkBxviid+AQtYNG9Ed7Et KCYoWTbncHT/ew6IVz0sTUGbj3x/BzQNYzubPfGsqak7xMzl3ikkVOT7lztJ6JLFvyNjZ9 ipYxa2Jm/15DPGhdVEO4gzPtrvxNgWcwkg6LQk5V7GallZg8S3NhWXO1vIQqhw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gwzBg40Vzz51 for ; Thu, 09 Jul 2026 15:18:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31a79 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 09 Jul 2026 15:18:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 45da2c1e1d20 - stable/15 - newvers.sh: Avoid spurious -dirty in git revision List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 45da2c1e1d202ab190f156dd63403be79fb11e94 Auto-Submitted: auto-generated Date: Thu, 09 Jul 2026 15:18:46 +0000 Message-Id: <6a4fbbd6.31a79.21eb34a9@gitrepo.freebsd.org> The branch stable/15 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=45da2c1e1d202ab190f156dd63403be79fb11e94 commit 45da2c1e1d202ab190f156dd63403be79fb11e94 Author: Ed Maste AuthorDate: 2026-07-01 14:35:10 +0000 Commit: Ed Maste CommitDate: 2026-07-09 15:18:31 +0000 newvers.sh: Avoid spurious -dirty in git revision If git is installed and .git exists but git rev-parse failed to report a hash we previously produced just "-dirty" as the git revision. Gate the git commit count and -dirty check on the rev-parse passing. Reviewed by: jlduran Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57995 (cherry picked from commit 465a3b7adc008c068741594f6c922ede98924f39) --- sys/conf/newvers.sh | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh index 7ce82a1af9f8..afd7e8c35d2b 100644 --- a/sys/conf/newvers.sh +++ b/sys/conf/newvers.sh @@ -260,21 +260,23 @@ fi if [ -n "$git_cmd" ] ; then git=$($git_cmd rev-parse --verify --short=12 HEAD 2>/dev/null) - if [ "$($git_cmd rev-parse --is-shallow-repository)" = false ] ; then - git_cnt=$($git_cmd rev-list --first-parent --count HEAD 2>/dev/null) - if [ -n "$git_cnt" ] ; then - git="n${git_cnt}-${git}" + if [ $? -eq 0 ]; then + if [ "$($git_cmd rev-parse --is-shallow-repository)" = false ] ; then + git_cnt=$($git_cmd rev-list --first-parent --count HEAD 2>/dev/null) + if [ -n "$git_cnt" ] ; then + git="n${git_cnt}-${git}" + fi fi + git_b=$($git_cmd rev-parse --abbrev-ref HEAD) + if [ -n "$git_b" -a "$git_b" != "HEAD" ] ; then + git="${git_b}-${git}" + fi + if git_tree_modified; then + git="${git}-dirty" + modified=yes + fi + git=" ${git}" fi - git_b=$($git_cmd rev-parse --abbrev-ref HEAD) - if [ -n "$git_b" -a "$git_b" != "HEAD" ] ; then - git="${git_b}-${git}" - fi - if git_tree_modified; then - git="${git}-dirty" - modified=yes - fi - git=" ${git}" fi if [ -n "$gituprevision" ] ; then