From owner-freebsd-current@freebsd.org Wed Oct 21 22:13:29 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19C86A1BD35 for ; Wed, 21 Oct 2015 22:13:29 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 0297A19C5; Wed, 21 Oct 2015 22:13:29 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id EFE6A1D81; Wed, 21 Oct 2015 22:13:28 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id B596116482; Wed, 21 Oct 2015 22:13:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 4FVjCvmSmCqO; Wed, 21 Oct 2015 22:13:26 +0000 (UTC) Subject: Re: [CFT] Buildworld ccache support DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 544311647D To: =?UTF-8?Q?Juan_Ram=c3=b3n_Molina_Menor?= , freebsd-current@freebsd.org References: <56264279.7020504@club.fr> <56279AD2.6080009@FreeBSD.org> <5627F937.4060301@club.fr> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <56280E07.50900@FreeBSD.org> Date: Wed, 21 Oct 2015 15:13:27 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5627F937.4060301@club.fr> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3THOVHGqnkfjmnpj1T2gCeGBKNmlwNHoM" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 22:13:29 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3THOVHGqnkfjmnpj1T2gCeGBKNmlwNHoM Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/21/2015 1:44 PM, Juan Ram=F3n Molina Menor wrote: > +.if ${CC:M/*} =3D=3D "" > +# Can use PATH. > +PATH:=3D ${CCACHE_WRAPPER_PATH}:${PATH} These lines in particular did have problems that I fixed recently. - It would potentially add /usr/local/libexec/ccache into PATH multiple times in sub-makes (I think, it may have been my own PATH confusing me). This would still use ccache. - It would consider the '-isystem /usr/obj/...' used for LIB32MAKE to match on '${CC:M/*}' which is intended to see if the compiler itself starts with a /. In this case of building during build32 ccache was not used. I have since added 'env CCACHE=3D1' to CC and an .info ${PATH} near this code to see if it is working and it sure seems to be working in all of the build. This does suggest that using the PATH method may not be good as it leads to confusion about whether it is used or not. I have seen ccache stats get really messed up before. They seemed stuck to me earlier. I had updated ccache in ports recently and had been building Poudriere using my global ccache dir. Outside of the jail I still had the older ccache. This may have led to it messing up my cache and stats. Once I upgraded ccache in the host and cleaned the cache it seemed to resume incrementing the counters. I've also since removed the CCP handling from the patch as I found that ccache just records a stat and bails out in that case. --=20 Regards, Bryan Drewery --3THOVHGqnkfjmnpj1T2gCeGBKNmlwNHoM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWKA4HAAoJEDXXcbtuRpfPEdkIAJsEF3yiDOeLFmpy8vXZ7gLO OacBKUnDmyPlNWpidNeqR4cQ+d2nZX8I7RKV/sufM5KTjaqffoyIWXekffvOMqfm F3cFirMg5/XCV5NLz4X6KLaxbUW4kokgraZK4+urK04xtSoxypfv4qiuLnoZ5rbP jeQWELIaZnlNymMG+6HoHkljrNjbCHRmLywtKwmVjHNvY5XzkqIYqWM04EswVLmJ tPL/CS8AICjvaEZ46g4tlKSTC5IPUFvvPFNLZmrqGgnj5DyoCYvn2oGfortKnnDp P1LkwV4t6joflNymi2/eubqI+/OC9jCAMYfcGESLdE3aXuSjhHKocvwXTTVrQaA= =XZ/U -----END PGP SIGNATURE----- --3THOVHGqnkfjmnpj1T2gCeGBKNmlwNHoM--