From owner-freebsd-bugs@FreeBSD.ORG  Mon Sep  8 21:51:48 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 872C9A97
 for <freebsd-bugs@FreeBSD.org>; Mon,  8 Sep 2014 21:51:48 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6EB01127F
 for <freebsd-bugs@FreeBSD.org>; Mon,  8 Sep 2014 21:51:48 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s88Lpm22071429
 for <freebsd-bugs@FreeBSD.org>; Mon, 8 Sep 2014 21:51:48 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 193471] New: Mismatched variable type in md5(1) from getopt
Date: Mon, 08 Sep 2014 21:51:48 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.0-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: webpages@sprow.co.uk
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-193471-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Sep 2014 21:51:48 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193471

            Bug ID: 193471
           Summary: Mismatched variable type in md5(1) from getopt
           Product: Base System
           Version: 10.0-STABLE
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: webpages@sprow.co.uk

The optarg from getopt(3) is defined as a char *, but md5 variable
'checkAgainst' is an unsigned type which leads to a warning on assignment and
later calls to strcmp (et al) when using a strict type check compiler.

Also, the variables may as well be static scope, as per the following patch
against SVN revision 238964 of /sbin/md5/md5.c

--- md5-238964.c    2014-09-08 22:45:27.0 +0100
+++ md5-new.c    2014-09-08 22:45:27.0 +0100
@@ -42,11 +42,11 @@
 #define TEST_BLOCK_COUNT 100000
 #define MDTESTCOUNT 8

-int qflag;
-int rflag;
-int sflag;
-unsigned char* checkAgainst;
-int    checksFailed;
+static int qflag;
+static int rflag;
+static int sflag;
+static char* checkAgainst;
+static int checksFailed;

 typedef void (DIGEST_Init)(void *);
 typedef void (DIGEST_Update)(void *, const unsigned char *, size_t);

-- 
You are receiving this mail because:
You are the assignee for the bug.