From owner-svn-src-all@FreeBSD.ORG Sun Jun 14 11:48:44 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0AEA6E39; Sun, 14 Jun 2015 11:48:44 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D3836AFA; Sun, 14 Jun 2015 11:48:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (unknown [137.122.64.71]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8B443B91F; Sun, 14 Jun 2015 07:48:41 -0400 (EDT) Message-ID: <557D6A19.8000301@FreeBSD.org> Date: Sun, 14 Jun 2015 07:48:41 -0400 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Oliver Pinter CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r284343 - in stable: 10/sys/kern 10/sys/sys 9/sys/kern 9/sys/sys References: <201506131615.t5DGFhUm038534@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Sun, 14 Jun 2015 07:48:42 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 11:48:44 -0000 On 6/14/15 6:39 AM, Oliver Pinter wrote: > On Sat, Jun 13, 2015 at 6:15 PM, John Baldwin wrote: > > Hi John! > > Could you please MFC this commit too: > > commit 4331ca7813ee01d1745c6ff2ced7030329586b30 > Author: jhb > Date: Fri May 22 11:09:41 2015 +0000 > > Expand ktr_mask to be a 64-bit unsigned integer. > > The mask does not really need to be updated with atomic operations and > the downside of losing races during transitions is not great (it is > not marked volatile, so those races are pretty wide open as it is). > > Differential Revision: https://reviews.freebsd.org/D2595 > Reviewed by: emaste, neel, rpaulo > MFC after: 2 weeks Hmm, I might not get too it in the near future. The only reason I've hesitated to do so is that it does slightly break the in-kernel ABI in that 'ktr_mask' is a public symbol to kernel modules. (I've used it in various hackish tests where I would clear ktr_mask to 0 when some unusual event happened so that the KTR trace buffer contained the events leading up to the unusual event.) OTOH, this is a bit of a special case, so I'm not sure if this is part of the ABI that we really have to worry about. -- John Baldwin