Date: Sat, 06 Feb 2021 17:51:34 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 253303] sysutils/memtest86+: remove dependency on gcc48 Message-ID: <bug-253303-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253303 Bug ID: 253303 Summary: sysutils/memtest86+: remove dependency on gcc48 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: kevans@freebsd.org Created attachment 222218 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222218&action= =3Dedit git(1) diff against the ports tree This is one of three ports still explicitly dependent on lang/gcc48. The problems that were preventing the upgrade were as follows: - The __OUT*/__IN* macros in io.h were declaring the produced functions as extern, yielding multiple "definitions." They're inline asm, so just give t= hem static linkage. - reboot was declared inline with non-static linkage, thus leaving it in a weird state where it wasn't visible within the same CU or another CU. Drop = the inline for now; if it really needs to be inlined, it can be moved into a he= ader and declared `static inline`. I made these changes, then discovered there's a 5.31b that's still in testi= ng. I checked the archive for that and was delighted to discover these changes = had already actually been made there, too, so let's consider this a backport. --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Maintainer informed via mail --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253303-7788>