Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Oct 2016 16:42:05 +0200
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Kris Moore <kmoore@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r423922 - in head/security: . ngrok
Message-ID:  <773bb4e0-00d2-6234-33ae-fdafce1135a7@FreeBSD.org>
In-Reply-To: <201610131431.u9DEVcA7079532@repo.freebsd.org>
References:  <201610131431.u9DEVcA7079532@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--CpcEASUK9rstFdmMQmLQT5HCCaB8PgHaD
Content-Type: multipart/mixed; boundary="9EatneOkdPNEgrrMTIel5o1cMV5h6WP6g";
 protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Kris Moore <kmoore@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <773bb4e0-00d2-6234-33ae-fdafce1135a7@FreeBSD.org>
Subject: Re: svn commit: r423922 - in head/security: . ngrok
References: <201610131431.u9DEVcA7079532@repo.freebsd.org>
In-Reply-To: <201610131431.u9DEVcA7079532@repo.freebsd.org>

--9EatneOkdPNEgrrMTIel5o1cMV5h6WP6g
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Le 13/10/2016 =C3=A0 16:31, Kris Moore a =C3=A9crit :
> +PORTNAME=3D	ngrok
> +PORTVERSION=3D	2.1.14
> +CATEGORIES=3D	security
> +MASTER_SITES=3D	https://bin.equinox.io/c/4VmDzA7iaHb/
> +DISTNAME=3D	${PORTNAME}-stable-freebsd-${NGROK_ARCH}
>

The DISTNAME seems to not have PORTVERSION in it. It means that when the
software is updated, there will be a second distfile with the same name,
which is a bad thing.  For those case, you should add:

DIST_SUBDIR=3D ${PORTNAME}/${PORTVERSIONS}

or something, so that there cannot be two different files with the same
name.


--=20
Mathieu Arnold



--9EatneOkdPNEgrrMTIel5o1cMV5h6WP6g--

--CpcEASUK9rstFdmMQmLQT5HCCaB8PgHaD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAEBCgBmBQJX/509XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IFPQQALtXHWSrBCrk+jW6NuusoRGA
InORUxyOUuvFXCIhSKRm8Fe5UYpVjg6dlV6Gfs+nS1yNx+sY4KcySZ+wc15TTJ7P
AJs5UNPdpwzjknwJ8q7FTumwxp5GaWAD7lYnaVmxrODeWAueOwKBeu4/NQa4Mdej
RZMlf73Pu1cPqvXIJe9jwG5PcJPhMCLJv8G3G8bXIwAlI/eIw+DhMk0vQ0kkybex
QJBxeilRJ8J8Qh+Q8I1zvUxUy12MudEt4BQlAE3FIW6JSBJ5KkxjgmLc0D89ipK1
Zm6XCN1ulRR6FDO7PwdwsCwxQRCrDlahVK2Elb37obUBBURS36unzYA5Tm3K1WMJ
vuCC9HRottetsBHkBunkS/rGupB5TqyKbqBrG/Y+tdKLipbu3oKZ2wmj9NyHdkTx
El7V8n8GNKzqdEiMzkAubTfh+gU4Mo9zTTv7yNooxCb/ZI1oWmJaDES4b/3d5RCm
WAAiH/HwzCp3+Fu19UbZVSU2Fn4SWcFtQVNut90hHQY3xPSJgQnQxorKQ/OVq8FC
kh7OkFyg+fVU2UWrDn2/s+HysEU0Ki/fTd2SAktcnfrWM4lhUBgLU/aiDGMfnv2A
bwYEoBgF1LU6a7Gegeo93pFfd6V8NQQAQUHFNm5Tas59Ihzssl5R0FgEJA2/kVTq
dG2wT3ibHmkrKlRqAhDj
=3LOp
-----END PGP SIGNATURE-----

--CpcEASUK9rstFdmMQmLQT5HCCaB8PgHaD--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?773bb4e0-00d2-6234-33ae-fdafce1135a7>