From owner-svn-src-all@freebsd.org Sun Feb 12 16:12:37 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6A08CDC0BF; Sun, 12 Feb 2017 16:12:37 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C6701A26; Sun, 12 Feb 2017 16:12:36 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id cwlJc10SBVQuxcwlKcxbA5; Sun, 12 Feb 2017 09:12:30 -0700 X-Authority-Analysis: v=2.2 cv=BNTDlBYG c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=n2v9WMKugxEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=v4_F-3648YwVUwcGbGEA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id E4025A02; Sun, 12 Feb 2017 08:12:28 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v1CGCS29009649; Sun, 12 Feb 2017 08:12:28 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201702121612.v1CGCS29009649@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: =?UTF-8?Q?Ermal_Lu=c3=a7i?= cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313675 - in head/sys: netinet netinet6 In-Reply-To: Message from =?UTF-8?Q?Ermal_Lu=c3=a7i?= of "Sun, 12 Feb 2017 06:56:33 +0000." <201702120656.v1C6uXp1008956@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 12 Feb 2017 08:12:28 -0800 X-CMAE-Envelope: MS4wfAaxqX3s6o4Fzx6H8UsdN0goaLpKPFg3m++n8dA4QKqObOqs6XHAV7GmQJN//nEe6+vzHfbfEREpvNxHxjSJd6ZvmWA1Un9I9A17JfwE2FKpRtUUKtRf GpuIQWbLy2L/zdLJKTjunWH5tyKb5XBAb7mhZ0+rk1mQ54OSHyRLFzhzF4QQcyWx/2yj/YC3hcl97nsvD2VIifSbKeiBZlpgKTJ7/iGSpJi2VqlOg759BLCn FQEN5rme8PcoXx3sA6/guN7pOEBGcXbxZl5hQ8xrRRUTGMUEf21L6sQgdLUGhU/I X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2017 16:12:37 -0000 In message <201702120656.v1C6uXp1008956@repo.freebsd.org>, =?UTF-8?Q?Ermal_Lu=c 3=a7i?= writes: > Author: eri > Date: Sun Feb 12 06:56:33 2017 > New Revision: 313675 > URL: https://svnweb.freebsd.org/changeset/base/313675 > > Log: > Committed without approval from mentor. This commit log message is objectionable and totally inappropriate. Revision numbers please? Providing the revision numbers after the fact doesn't completely address my objection to the incompleteness of this commit log message because the commit log is now incomplete for all posterity. The revision numbers are missing from the commit log and anyone going through the history of the affected sources (I do that a lot) has no clue, except to try to piece together what was backed out and search for replies to commit email to provide a complete picture of what was done. Vital information is missing from the commit log. Searching for answers to these questions is time consuming and incomplete documentation is inconsiderate and disrespectful of those who follow on figure out what and why. Looking up mentor/mentee relationships, one can safely assume that your mentor requested the backout. This too should have been documented in the commit log message, e.g. "(mentor)". At the very least revision numbers should be documented in a follow up eamil. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.