From owner-freebsd-dtrace@freebsd.org Fri Aug 4 17:42:21 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E71E5DC05FC for ; Fri, 4 Aug 2017 17:42:21 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt0-x22a.google.com (mail-qt0-x22a.google.com [IPv6:2607:f8b0:400d:c0d::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9CF2671101 for ; Fri, 4 Aug 2017 17:42:21 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt0-x22a.google.com with SMTP id v29so13019100qtv.3 for ; Fri, 04 Aug 2017 10:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FAoM3DI1lSPSMcdA9FoX4Jr7utPLCZHmN6YeQx3zrRQ=; b=RqHatPBnyJ+0C0cEKhEXZ8Dp1+oke7jEGy+IQZbUiPCnOHhHvJHujnt4PovYMqvDf1 LGsSQGk0gKks+dbTWxcTPQtFHWOwFQ4VsA3OVAOpd82z1eMyyQA2l7NtB+7CMtJIPpmI XcDni/c60nlXmUFUVQvbj+3QFIXDWg8k76utGO1XHN2ajCxL9MPfKPbq8Wl8m2V5Y8/c WLiOjQvSPQP81Z6zrgiw/go0bGlG6GWG3xI9Zh73x1l7q63eRjNLEhBsDPqnApPvBCZx Ciw19lB3mvfFohyyJ7iljMMojod6+m2hkN2Bh6zNYnaEO7tIoB68hI9S6NyLl7zxg6Mr JdtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=FAoM3DI1lSPSMcdA9FoX4Jr7utPLCZHmN6YeQx3zrRQ=; b=p3JgB7Z1d3Xn9ND5IYQXEMxwd9ZsmEc39ORJhoWe4t4eZP3hR6i+fWNGGhkLPQof8E gdgqmpt5zvMvsUW0LXbt45tg3PW9iYpCoduvV4bPpxjadZXYhm7LJAiHcosnzAGSfw0H l7BEDhs4CKGMPCPJy2soU8DjlvfLfjlqSRbgfICqnxv1Jd2P3mZ9Xlv6VQXWGXCjng6B sxSBVwe0jajCFUd2mTfDMH9HdKHT1YzT2eRFczkrDYOH9bls5P/C+ubAjCHs5GFOgEhC XYE0ilzc45FC1tEtISZphuFq/W2oL3DyZJZwpchws/FW7G7Xqq4IDXupM+4/54P6nuzb keLg== X-Gm-Message-State: AHYfb5gLMJjabSk8TF6OTH2J4ZT8wdEOvrBOOvjPnYywRl6NHGsJriRO zSx3P+ylE/ULs7dV X-Received: by 10.237.34.194 with SMTP id q2mr4729015qtc.255.1501868540664; Fri, 04 Aug 2017 10:42:20 -0700 (PDT) Received: from wkstn-mjohnston.west.isilon.com (c-76-104-201-218.hsd1.wa.comcast.net. [76.104.201.218]) by smtp.gmail.com with ESMTPSA id l47sm1477235qtc.64.2017.08.04.10.42.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Aug 2017 10:42:20 -0700 (PDT) Sender: Mark Johnston Date: Fri, 4 Aug 2017 10:43:24 -0700 From: Mark Johnston To: Andreas Longwitz Cc: "freebsd-dtrace@freebsd.org" Subject: Re: g_journal_read has broken argument list in V10 Message-ID: <20170804174324.GA66372@wkstn-mjohnston.west.isilon.com> References: <596F2CDA.1000705@incore.de> <598343D8.8060101@incore.de> <20170803171011.GB4968@wkstn-mjohnston.west.isilon.com> <5984507A.3090104@incore.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5984507A.3090104@incore.de> User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 17:42:22 -0000 On Fri, Aug 04, 2017 at 12:46:18PM +0200, Andreas Longwitz wrote: > By the way, the following patch solves the problem with the wrong > argument counts in ctfdump: I think the existing code is correct. It's printing the CTF type index of the return type, not the number of arguments. In particular, we have: <1> INTEGER void encoding=SIGNED offset=0 bits=0 so "returns 1" just means that the return type is void. > > --- dump.c.1st 2015-07-03 16:39:24.000000000 +0200 > +++ dump.c 2017-08-04 10:56:21.563805000 +0200 > @@ -364,7 +364,8 @@ > (void) printf(" [%lu] FUNC ", id); > if (name != NULL) > (void) printf("(%s) ", name); > - (void) printf("returns: %u args: (", *fp++); > + (void) printf("returns: %u args: (", n); > + fp++; > > if (n != 0) { > (void) printf("%u", *fp++);