Date: Fri, 14 Aug 2015 14:24:43 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: "Pedro F. Giffuni" <pfg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286760 - in head/lib/libc: . secure sys Message-ID: <20150814112443.GL2072@kib.kiev.ua> In-Reply-To: <201508140303.t7E33EnN095618@repo.freebsd.org> References: <201508140303.t7E33EnN095618@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 14, 2015 at 03:03:14AM +0000, Pedro F. Giffuni wrote: > +/* > + * It'd be nice to have this automatically generated, but we don't > + * know to what version they will eventually belong, so for now > + * it has to be manual. > + */ The comment does not make a bit of sense. It also raises the question whether the author(s) of the change ever understand what do they change. > +FBSD_1.0 { > + __chk_fail; > + __stack_chk_fail; > + __stack_chk_guard; > +};
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150814112443.GL2072>