From owner-freebsd-net Fri Aug 16 3:19:45 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A648637B400; Fri, 16 Aug 2002 03:19:40 -0700 (PDT) Received: from mail.otel.net (gw3.OTEL.net [212.36.8.151]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D0D843E81; Fri, 16 Aug 2002 03:19:39 -0700 (PDT) (envelope-from ikostov@otel.net) Received: from judicator.otel.net ([212.36.9.113]) by mail.otel.net with esmtp (Exim 3.36 #1) id 17feCY-0008Wo-00; Fri, 16 Aug 2002 13:19:30 +0300 Date: Fri, 16 Aug 2002 13:19:30 +0300 (EEST) From: Iasen Kostov To: Julian Elischer Cc: Maxim Sobolev , , Subject: Re: Increasing size of if_flags field in the ifnet structure [patch for review] In-Reply-To: Message-ID: <20020816131654.H18061-100000@shadowhand.OTEL.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Please take a look at this patch. It implement 1 more flag to if_flags and ofcourse it increases size of this flag field by using if_ipending which is unused. On Thu, 15 Aug 2002, Julian Elischer wrote: > you cannot break ABIs in 4.x > in 5.x it will probably be ok until (say) 5.1 or something. > > > On Thu, 15 Aug 2002, Maxim Sobolev wrote: > > > Folks, > > > > When implementing ability to switch interface into promisc mode using > > ifconfig(8) I've stumbled into the problem with already exhausted > > space in the `short if_flags' field in the ifnet structure. I need to > > allocate one new flag, while we already have 16 IFF_* flags, and even > > one additional flag which is implemented using currently free > > if_ipending field of the said structure. Attached patch is aimed at > > increasing size of if_flags to 32 bits, as well as to clean-up > > if_ipending abuse. Granted, it will break backward ABI compatibility, > > but IMO it is not a big problem. > > > > Comments and suggestions are greatly appreciated. Thanks! > > > > -Maxim > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-net" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message