From owner-svn-src-all@freebsd.org Mon Oct 12 01:55:47 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D23719D2948 for ; Mon, 12 Oct 2015 01:55:47 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm6.bullet.mail.bf1.yahoo.com (nm6.bullet.mail.bf1.yahoo.com [98.139.212.165]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 846811D33 for ; Mon, 12 Oct 2015 01:55:47 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1444614940; bh=sN6053TII39oyuqyLwk9d2CwMGdii2+uErht5nr7Aks=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=Q/4TcS7lyr2iDj0f3SOUKg6WRJXrhJkUDVCGKZP7ZNDQESJLs642+PVkqnY5I8mICh8W50qYFvx0O4ceDbnYpEHlfrWHMV1vOOdgzly7kGy2LzBl821cjrXtyE4P+uivCXj9T1r6roJX7dRgSnZDElYpnGHePO5p3wW/A2XuTxUu4sPI78htXx2wkyMIpJxff0llxfS86tVNmue/uadZnM70CmIOUkjMjXivZCCEUEDnobzget4SkPHZx6xDrVrmKHxJGZbgi5/aWwK4FCU8YsojJQKFo7leGpQ5R/+BUHzOsA10hieg97a80lgt20mGF3eOH1lF8BYcQVvqDPVlWQ== Received: from [66.196.81.172] by nm6.bullet.mail.bf1.yahoo.com with NNFMP; 12 Oct 2015 01:55:40 -0000 Received: from [98.139.211.196] by tm18.bullet.mail.bf1.yahoo.com with NNFMP; 12 Oct 2015 01:55:40 -0000 Received: from [127.0.0.1] by smtp205.mail.bf1.yahoo.com with NNFMP; 12 Oct 2015 01:55:40 -0000 X-Yahoo-Newman-Id: 253285.65294.bm@smtp205.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: yUklFI4VM1k92yFzUMuv4w3AFj4ntsfed2fliYX3hute.9k _4pzQdrIcy6tiS_asXKQTR.s0z3ZG_dg_oO8ytTskHSLKXc8Ro9BeDppOr3x BqsyZ9mXHb1IkjsC0NXgf6SmTUpExC7MybAxpFvPoTad_2Y1KtV_5S7Inocq 7J66PKyLuq7DhLdae260d_1Qqps.PHhbMd4YdAmFeVPkMX.1jOHhc_npPbdQ hhSuG.D4DrXFUZ7ggN.TZeV_9heqE3UjAGP8ZwZFU4ESSZHzIG3MKD.71OD4 gTKvsQoqXCf3JIAVrwyTCpSaDiDIz5RC5rg9aclfWVo.yGu5XYoq8NvVQo74 uWZ32_aX7Jf0atDc_jJFruv9nVM80ub0IJHf5HljA_sCws1h5jOOsH56QW91 bbLwGax5Mi2ta6zRZTbEhchoHbvgme0IO_KFJzcnLEactFJKw4q3Oxpehv7Q Z5gbKsRQwwJsi8j6sT2uzqZngQ1Nn5UCDmiwChli2wZ3u1BXqHVppqe8FqRW ZqXHQSxhZGMUqQtPnJHaR1VVEmfGBvnBP X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r289150 - head/contrib/gcc/cp To: Adrian Chadd References: <201510111958.t9BJwvuI069443@repo.freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Pedro Giffuni Organization: FreeBSD Project Message-ID: <561B1314.4070106@FreeBSD.org> Date: Sun, 11 Oct 2015 20:55:32 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2015 01:55:48 -0000 On 11/10/2015 07:20 p.m., Adrian Chadd wrote: > Heya! > > How'd you test this? Sean is reporting (on irc) there's some weirdness > after this commit. Hmm... I only rebuilt it and ran minimal tests in my box. It only looked imporant for mesa. I will revert to investigate, thanks for the report. Pedro. > > -a > > > On 11 October 2015 at 12:58, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Sun Oct 11 19:58:57 2015 >> New Revision: 289150 >> URL: https://svnweb.freebsd.org/changeset/base/289150 >> >> Log: >> Correct handling of enum attributes with g++ >> >> From OpenBSD's commit log: >> >> This was responsible for memory corruption with recent versions >> of Mesa where c and c++ code share a header with a packed enum type. >> >> Reference: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39219 >> >> Obtained from: OpenBSD (CVS rev. 1.2) >> MFC after: 1 week >> >> Modified: >> head/contrib/gcc/cp/parser.c >> >> Modified: head/contrib/gcc/cp/parser.c >> ============================================================================== >> --- head/contrib/gcc/cp/parser.c Sun Oct 11 19:30:09 2015 (r289149) >> +++ head/contrib/gcc/cp/parser.c Sun Oct 11 19:58:57 2015 (r289150) >> @@ -10906,6 +10906,7 @@ cp_parser_enum_specifier (cp_parser* par >> if (cp_parser_allow_gnu_extensions_p (parser)) >> { >> tree trailing_attr = cp_parser_attributes_opt (parser); >> + trailing_attr = chainon (trailing_attr, attributes); >> cplus_decl_attributes (&type, >> trailing_attr, >> (int) ATTR_FLAG_TYPE_IN_PLACE); >>