From owner-cvs-all  Sun Jun 16 20:45:19 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 617A837B414; Sun, 16 Jun 2002 20:45:15 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id NAA01337;
	Mon, 17 Jun 2002 13:45:04 +1000
Date: Mon, 17 Jun 2002 13:49:44 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Garrett Wollman <wollman@lcs.mit.edu>
Cc: Dag-Erling Smorgrav <des@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/drm drm_os_freebsd.h
In-Reply-To: <200206170103.g5H13wGP087029@khavrinen.lcs.mit.edu>
Message-ID: <20020617134613.A3073-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 16 Jun 2002, Garrett Wollman wrote:

> <<On Sun, 16 Jun 2002 14:50:43 -0700 (PDT), Dag-Erling Smorgrav <des@FreeBSD.org> said:
>
> >   Remove <sys/select.h> to unbreak the build.  I'm not sure if this affects
> >   the functionality of the drm module, but hopefully it will tide us over
> >   until Eric can take a look at it.
>
> It cannot possibly have affected the functionality, since
> <sys/select.h> was previously empty.

Please fix misuses of <sys/select.h> all over the kernel.  There seems to
be only one complete misuse (in smb_dev.c).  This happens to compile
because <sys/signalvar.h> is not included.  There are many includes of
<sys/select.h> in ugly ifdefs.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message