Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Jun 2002 13:49:44 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Garrett Wollman <wollman@lcs.mit.edu>
Cc:        Dag-Erling Smorgrav <des@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/dev/drm drm_os_freebsd.h
Message-ID:  <20020617134613.A3073-100000@gamplex.bde.org>
In-Reply-To: <200206170103.g5H13wGP087029@khavrinen.lcs.mit.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 16 Jun 2002, Garrett Wollman wrote:

> <<On Sun, 16 Jun 2002 14:50:43 -0700 (PDT), Dag-Erling Smorgrav <des@FreeBSD.org> said:
>
> >   Remove <sys/select.h> to unbreak the build.  I'm not sure if this affects
> >   the functionality of the drm module, but hopefully it will tide us over
> >   until Eric can take a look at it.
>
> It cannot possibly have affected the functionality, since
> <sys/select.h> was previously empty.

Please fix misuses of <sys/select.h> all over the kernel.  There seems to
be only one complete misuse (in smb_dev.c).  This happens to compile
because <sys/signalvar.h> is not included.  There are many includes of
<sys/select.h> in ugly ifdefs.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020617134613.A3073-100000>