From nobody Fri Aug 11 22:52:00 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RMzZC52P4z4prsq for ; Fri, 11 Aug 2023 22:52:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RMzZC3fW3z4FkT for ; Fri, 11 Aug 2023 22:52:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691794323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MMpiaddU/DPfmuYREFDFXV0J01Q81dedMWyp5ZyIJrk=; b=x19GkLVYoOOMjqCJB4XCHdDQQK+Hux37ecK7fN3uZMKEFI16IZkhHIFtih6ZpT17lpvHem Ra8Tv/rnnycEbaPEhQn7xJIVH06zRpnxXlP0K48lkjA3lm/XD3c0yQrysDJhSrVjDSLgCg hrPcFyLHkGUYiWAAv+qXJp8DgrJcqe/jairdb9B13nMOaGfcOXXjoOOkFzEolsrGSXA4X0 Dslk2Lg2S5CyIjxjDtbEGrI3zvGrRG5euO2FIQ1LJu1a91BxNxMmIadbwLOQWp2pK2RyYb VrHTY/k308np39tbhbEF08r5mjJr0UNrEyglt89oLJOEvi32QNRBv1uzjgPIrA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691794323; a=rsa-sha256; cv=none; b=nD2PpUICcpUOCtwffS2iffoJhXcoVmAMqU75Xy/M5R4AvuXsz06gPyucwxjLS5wiDjQ8zn FORVvQJlXnn+Q3Rivxoy1vY6jOvtsba34jQgpsvFJN9953BJLC4OBnQUSPFpu+MNSYr/z4 WwRV3TK8aOo59Hj8EHCuDOT5/F8pHPln3i98KqV6N0PvFeeDNqI8hKn6tOoAFbIL4vZVSm YjVSAhy+7PRKuDhTHyH4TOBqXwBrObItW4GdR7ucrU+JiESD2zwTS+KfEMuf38dxrH7A5w p3ZhH4/hK5ynTXpQJ2qvYjwzsFmdo2yRWjFWdUn/sBJmRt1Ww5VWX4sVcjqVSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RMzZC2l79zxGT for ; Fri, 11 Aug 2023 22:52:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 37BMq3jF095350 for ; Fri, 11 Aug 2023 22:52:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 37BMq3QP095349 for net@FreeBSD.org; Fri, 11 Aug 2023 22:52:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 254596] if_bridge wants LRO turned off, if_vlan insists it remain on Date: Fri, 11 Aug 2023 22:52:00 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254596 --- Comment #14 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D5f11a33ceeb385477cb22d9ad5941061c= 5a26be9 commit 5f11a33ceeb385477cb22d9ad5941061c5a26be9 Author: Paul Vixie AuthorDate: 2023-08-11 18:17:16 +0000 Commit: Kristof Provost CommitDate: 2023-08-11 22:50:37 +0000 if_vlan: do not enable LRO for bridge interaces If the parent interface is not a bridge and can do LRO and checksum offloading on VLANs, then guess it may do LRO on VLANs. False positive here cost nothing, while false negative may lead to some confusions. According to Wikipedia: "LRO should not operate on machines acting as routers, as it breaks the end-to-end principle and can significantly impact performance." The same reasoning applies to machines acting as bridges. PR: 254596 MFC after: 3 weeks sys/net/if_vlan.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=