Date: Wed, 20 May 2020 20:41:05 -0600 From: Ian Lepore <ian@freebsd.org> To: Wei Hu <weh@microsoft.com>, Enji Cooper <yaneurabeya@gmail.com>, Shawn Webb <shawn.webb@hardenedbsd.org> Cc: Wei Hu <whu@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r361275 - in head/sys: conf dev/hyperv/hvsock dev/hyperv/include dev/hyperv/vmbus modules/hyperv modules/hyperv/hvsock sys Message-ID: <761b75a4ad0a4630bce26aad1b03137ac45509fd.camel@freebsd.org> In-Reply-To: <SG2P153MB0377A14BB83B74CB60082BE2BBB70@SG2P153MB0377.APCP153.PROD.OUTLOOK.COM> References: <BEA42C4A-6406-4ACB-A867-3E4F353E23C9@gmail.com> <FC54306E-51A0-45A4-944C-F2BC87916BE1@gmail.com> <SG2P153MB0377A14BB83B74CB60082BE2BBB70@SG2P153MB0377.APCP153.PROD.OUTLOOK.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2020-05-21 at 01:53 +0000, Wei Hu wrote: > > -----Original Message----- > > From: Enji Cooper <yaneurabeya@gmail.com> > > Sent: Wednesday, May 20, 2020 11:58 PM > > To: Shawn Webb <shawn.webb@hardenedbsd.org> > > Cc: Wei Hu <whu@freebsd.org>; src-committers@freebsd.org; svn-src- > > all@freebsd.org; svn-src-head@freebsd.org > > Subject: Re: svn commit: r361275 - in head/sys: conf dev/hyperv/hvsock > > dev/hyperv/include dev/hyperv/vmbus modules/hyperv > > modules/hyperv/hvsock sys > > > > > > > On May 20, 2020, at 08:54, Enji Cooper <yaneurabeya@gmail.com> wrote: > > > > > > > > On May 20, 2020, at 08:11, Shawn Webb <shawn.webb@hardenedbsd.org> > > > > wrote: > > > > > > > > > > On Wed, May 20, 2020 at 11:03:59AM +0000, Wei Hu wrote: > > > > > Author: whu > > > > > Date: Wed May 20 11:03:59 2020 > > > > > New Revision: 361275 > > > > > URL: > > > > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsv > > > > > > > > > nweb.freebsd.org%2Fchangeset%2Fbase%2F361275&data=02%7C01%7C > > weh% > > > > > > > > > 40microsoft.com%7Cd6ff3617bffa43d10a7708d7fcd68470%7C72f988bf86f141 > > a > > > > > > > > > f91ab2d7cd011db47%7C1%7C0%7C637255870581110888&sdata=mzz6R > > ILCVBk > > > > > q06RI1PAfVNKWZO2y7jBO0C1E%2F%2FEJwUY%3D&reserved=0 > > > > > > > > > > Log: > > > > > HyperV socket implementation for FreeBSD > > > > > > > > > > This change adds Hyper-V socket feature in FreeBSD. New socket > > > > > address family AF_HYPERV and its kernel support are added. > > > > > > Hi Wei, > > > Could you please further describe what this feature is/does? > > > > I realize after looking at the review that it contains the content I was hoping > > for. It would have been helpful to folks if this context had been included in the > > commit message. > > Hi Enji, > > I thought I just keep it simple for the commit log message while people can > refer to the review site for details. Sorry about that. Let me know if there is > anyway to make up for it. > > Wei > Ten years from now, phabricator may just be a fading memory, but the source code repo lives forever. Usually when I put something in phab for review, the description I enter in phab is exactly the text I intend to use when committing the change. That helps the people doing the review... the description is an overview of what is being changed, and most importantly, why it is being changed (fixes a bug, adds a new feature, better performance, etc). Everything you say there to help reviewers will be equally helpful in the repo history when someone needs to research some day why a change got made. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?761b75a4ad0a4630bce26aad1b03137ac45509fd.camel>