From owner-cvs-all@FreeBSD.ORG  Sat Mar  8 18:34:18 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2287B1065670;
	Sat,  8 Mar 2008 18:34:18 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id ECEEF8FC19;
	Sat,  8 Mar 2008 18:34:17 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m28IYH41035883;
	Sat, 8 Mar 2008 18:34:17 GMT (envelope-from bz@repoman.freebsd.org)
Received: (from bz@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m28IYHB6035877;
	Sat, 8 Mar 2008 18:34:17 GMT (envelope-from bz)
Message-Id: <200803081834.m28IYHB6035877@repoman.freebsd.org>
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
Date: Sat, 8 Mar 2008 18:34:17 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: RELENG_6
Cc: 
Subject: cvs commit: src/sys/netipsec key.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Mar 2008 18:34:18 -0000

bz          2008-03-08 18:34:17 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/netipsec         key.c 
  Log:
  MFC rev. 1.25
  
    Add a missing return so that we drop out in case of an error and
    do not continue with a NULL pointer. [1]
  
    While here change the return of the error handling code path above.
    I cannot see why we should always return 0 there. Neither does KAME
    nor do we in here for the similar check in all the other functions.
  
    Found with:     Coverity Prevent(tm) [1]
    CID:            2521
  
  Revision  Changes    Path
  1.20.2.3  +2 -3      src/sys/netipsec/key.c