From owner-svn-src-all@FreeBSD.ORG Mon Dec 6 18:45:06 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 507DE106566B; Mon, 6 Dec 2010 18:45:06 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id CBC9B8FC0A; Mon, 6 Dec 2010 18:45:05 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id DD3B045C9B; Mon, 6 Dec 2010 19:45:02 +0100 (CET) Received: from localhost (89-73-192-49.dynamic.chello.pl [89.73.192.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 1175845C89; Mon, 6 Dec 2010 19:44:55 +0100 (CET) Date: Mon, 6 Dec 2010 19:44:53 +0100 From: Pawel Jakub Dawidek To: Ivan Voras Message-ID: <20101206184453.GA1936@garage.freebsd.pl> References: <201012061218.oB6CI3oW032770@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lrZ03NoBR/3+SXJZ" Content-Disposition: inline In-Reply-To: <201012061218.oB6CI3oW032770@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216230 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Dec 2010 18:45:06 -0000 --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 06, 2010 at 12:18:03PM +0000, Ivan Voras wrote: > Author: ivoras > Date: Mon Dec 6 12:18:02 2010 > New Revision: 216230 > URL: http://svn.freebsd.org/changeset/base/216230 >=20 > Log: > Use GEOM stripesize field when calculating ashift. This will enable cor= rect > alignment on drives with large sector sizes (e.g. 4 KiB) but the > implementation might need to be revisited if devices with large stripes= izes > appear (e.g. if RAID controllers or flash drives start using the field), > probably by introducing a physsectorsize field in GEOM providers. Please back this out as soon as possible! > Discussed with: mav, mostly silence on freebsd-geom@ and freebsd-fs@ Guess why it wasn't picked up by anyone? > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c >=20 > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c Mon D= ec 6 11:37:24 2010 (r216229) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c Mon D= ec 6 12:18:02 2010 (r216230) > @@ -496,7 +496,10 @@ vdev_geom_open(vdev_t *vd, uint64_t *psi > /* > * Determine the device's minimum transfer size. > */ > - *ashift =3D highbit(MAX(pp->sectorsize, SPA_MINBLOCKSIZE)) - 1; > + if (pp->stripesize > pp->sectorsize) > + *ashift =3D highbit(MIN(pp->stripesize, SPA_MAXBLOCKSIZE)) - 1; > + else > + *ashift =3D highbit(MAX(pp->sectorsize, SPA_MINBLOCKSIZE)) - 1; Even in this chunk there is a comment explaining perfectly what ashift stands for!! --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --lrZ03NoBR/3+SXJZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkz9LyUACgkQForvXbEpPzQGzgCfQMaGcITMc8XXPnD+nVk1Pgei /MAAoKDqaJ/5bRNXzlP/wu62guEWpgcg =icls -----END PGP SIGNATURE----- --lrZ03NoBR/3+SXJZ--