From owner-svn-src-head@FreeBSD.ORG Mon Dec 2 03:24:00 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E0DF395B for ; Mon, 2 Dec 2013 03:24:00 +0000 (UTC) Received: from mail-qa0-x235.google.com (mail-qa0-x235.google.com [IPv6:2607:f8b0:400d:c00::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9749F6CF7 for ; Mon, 2 Dec 2013 03:24:00 +0000 (UTC) Received: by mail-qa0-f53.google.com with SMTP id j5so3894059qaq.5 for ; Sun, 01 Dec 2013 19:23:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=HrcwzxpxkBpF2tmiUMK/8e2LuFWoOUy6NeZNi7juCFI=; b=tRuO/1LhqOL17kky+DdXwv6sEo55o7shRCMN/oO2Ev0X8XGHuVIiLRve99ItoFsVRm K3L0D9ICZOBRKdhii4z5D/GbWHpa4vhynL0iCe9AaFfci7HH8p9+rgxE4yIM/mckBoP2 DMDWBhGCOiBlcre+A7ySu17qqH+IZWyxUbIbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=HrcwzxpxkBpF2tmiUMK/8e2LuFWoOUy6NeZNi7juCFI=; b=JuG3lyGMcvLXINjf/l+36Uds3LahK9BEMT5B13nHURhMQFlHBHdcCcCVgD9U12PWdX ed3Cz1a7wYOQCEQk/9M9jQCnUAk/rRdv0r0bPKFCBPXE9Jf4JX2hZxoVJfV8nJsSaGq5 FXch9XIye7kaIMZhzcp0pGiZcdaNMS5410U0Np4FZEk2N1EsnXjCE/FGnJvfvpMoGGsj ZXpbP2cJaNigY8Et9pMeOqHoRL/NZOYYVvUGuTIPI76ipiqeheLxueT/TNVzfudACYAE M9cKbfA0oC0/NHYYo986c/ZC1rj0LChkl7XWtErx2jqBj5+e0DlvhV03Ti73i0+nZz2y jHLA== X-Gm-Message-State: ALoCoQla6BpOEpjbfMoy2RUvp12FMFuehfjliyfJYTSeONIwO+cBRs2d3YtXuOZA4BKMFOcmtfE6 X-Received: by 10.224.75.9 with SMTP id w9mr45111296qaj.68.1385954639609; Sun, 01 Dec 2013 19:23:59 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.86.42 with HTTP; Sun, 1 Dec 2013 19:23:29 -0800 (PST) In-Reply-To: <20131201230735.GB24849@stack.nl> References: <201311302216.rAUMGcPA037268@svn.freebsd.org> <20131201075944.GF59496@kib.kiev.ua> <20131201230735.GB24849@stack.nl> From: Eitan Adler Date: Sun, 1 Dec 2013 22:23:29 -0500 X-Google-Sender-Auth: Pp0TPXzJK0tXNCzXdXTEGK1XL2c Message-ID: Subject: Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm To: Jilles Tjoelker Content-Type: text/plain; charset=UTF-8 Cc: Konstantin Belousov , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 03:24:00 -0000 On Sun, Dec 1, 2013 at 6:07 PM, Jilles Tjoelker wrote: >> Revert the drm2/i915 changes from this and following commits now. >> You did not contacted obvious maintainer of the file. Of course I did not. This was discussed on arch@ and the change made mechanically. >> The changes are pointless and make the import of upstream changes >> harder; for i915_reg.h, much harder. > > This is a valid concern. The change should be submitted to upstream; if > upstream does not want the change, it is better to avoid the issue by > adding -fno-strict-overflow for the offending files, matching upstream. I will revert to the broken and incorrect code in sys/dev/drm2/i915. Upstream should be contacted with the patch. >> Not to mention that the whole churn is not needed if the >> -fno-strict-overflow flag is used. > > I think the undefined shifts should be fixed where possible and not in > contributed code. Agreed. In addition, contributed code ought to be clearly differentiated in the directory hierarchy. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams