From owner-freebsd-current  Thu Jan 25 13:30:22 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id NAA27859
          for current-outgoing; Thu, 25 Jan 1996 13:30:22 -0800 (PST)
Received: from ki.net (ki.net [142.77.249.8])
          by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id NAA27793
          for <current@freebsd.org>; Thu, 25 Jan 1996 13:30:16 -0800 (PST)
Received: (from scrappy@localhost) by ki.net (8.7.3/8.7.3) id QAA12607; Thu, 25 Jan 1996 16:29:44 -0500 (EST)
Date: Thu, 25 Jan 1996 16:29:43 -0500 (EST)
From: "Marc G. Fournier" <scrappy@ki.net>
To: current@freebsd.org
Subject: ether_sprintf bug: possible patch?
Message-ID: <Pine.BSF.3.91.960125162519.9225c-100000@ki.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-current@freebsd.org
Precedence: bulk


Hi...

	Just searched through if_ed.c, which is dated as being last
modified yesterday (Jan24) to see if I can find what is going on, and
found this:

<excerpt from if_ed.c>
        /*
         * Print additional info when attached
         */
        printf("ed%d: address %6D, ", isa_dev->id_unit,
                sc->arpcom.ac_enaddr, ":");

        if (sc->type_str && (*sc->type_str != 0))
                printf("type %s ", sc->type_str);
        else
                printf("type unknown (0x%x) ", sc->type);

        printf("%s ", sc->isa16bit ? "(16 bit)" : "(8 bit)");

        printf("%s\n", ((sc->vendor == ED_VENDOR_3COM) &&
               (ifp->if_flags & IFF_ALTPHYS)) ? " tranceiver disabled" : "");
ki# grep ether_sprintf if_ep.c
    printf(" address %s", ether_sprintf(sc->arpcom.ac_enaddr));


	Can someone clarify for me as to whether I would be correct in 
assuming that the following "patch" would work or break something?  I'm
going to to try it, but, if I'm missing something due to ignorance... :(

*** if_ep.c.orig        Thu Jan 25 16:28:22 1996
--- if_ep.c     Thu Jan 25 16:28:53 1996
***************
*** 408,414 ****
        GO_WINDOW(2);
        outw(BASE + EP_W2_ADDR_0 + (i * 2), ntohs(p[i]));
      }
!     printf(" address %s", ether_sprintf(sc->arpcom.ac_enaddr));

      /*
       * Write IRQ value to board
--- 408,414 ----
        GO_WINDOW(2);
        outw(BASE + EP_W2_ADDR_0 + (i * 2), ntohs(p[i]));
      }
!     printf(" address %6D", sc->arpcom.ac_enaddr);

      /*
       * Write IRQ value to board


Marc G. Fournier | POP Mail  Telnet Acct  DNS Hosting
System           |  WWW Services   Database Services  | Knowledge, 
  Administrator  |                                    | Information and
 scrappy@ki.net  |      WWW: http://www.ki.net        | Communications, Inc