From nobody Sun Sep 21 08:29:02 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cTzt94C3Lz67kh8; Sun, 21 Sep 2025 08:29:05 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cTzt93CkFz3JVH; Sun, 21 Sep 2025 08:29:05 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758443345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KljZt/FW2m1MjYrZCIYejKY+UGVRx2OfUlE6syj+DKY=; b=YVpLGCD+rPjo3PI37VxhDWDijXp8H4qgzVb7UFmLuImCuG2JEuzjOTOGbW/5Aig3gXHTAs FhH2V7lGI7Ttzn9T6d2/FDfF/PfUg6AlY4k+jAFoaKUU3wWGth9B/zNpJa+jgXzPDIjwjw MQ+nAcCuEInYRtbUiLJw+/F5JO8bVXvZ3+rm5RT11XE1y+qcYSz1JT/mRF28dI/h5Yda3F cISMQeRUl3JEsd5UFzO1QEz5YSsCRtFp6jxceRmEJq9bf6oLMmfSrOC+FFgUEtstF9jy70 O2cSwYaEyOQj7/Xm4NPo/gCIZUjvbXv4sRrWLjRyx9E6vZu6urby7UhkiREFHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758443345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KljZt/FW2m1MjYrZCIYejKY+UGVRx2OfUlE6syj+DKY=; b=goRB88CmNmEk7Z00h8XzrcyVVJ/RVwwIWiLCAcD170uVc3Kq6QUvsJqpSmA52eEzkI/P/6 chDU2c1LzV0I9aPgSbOPdHy5bIVo+MXCcIp4CDp/thNO7CKJqwZpQ32UJZ3m5TGICK6RO8 J2YDXqdCOfgtomhFFYpTAASd6SVOQMUwk+YnX7740M7MR1qo7QQAdKr8sDC/QJWvmeI2eI JTM8dGAfcXdmmFvzpt+YHDgvFcAtJvdQzl1L6wsglxUjT5bzBobCGd2n2IboV0lbNNHbN9 vknNuCSfcT3T23g+4GoJuGNQQAb3koqwt3gN12xGp6s19CPzA3U/Cj0gAC6Oiw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758443345; a=rsa-sha256; cv=none; b=L9qVcuYleE/rh9ZV6pMMEOTlkx4khK5SHUUZEIqmlVFSbKCZC49Z4nJo5la6mMDspjEA8D f5Yr0QzEUbu56/IWl1CjqVe7l2E3rbaUn/vAgwPXxRgUIRBrePkTjbWO/uhyU+EcOqLLO1 SLqSEcQRlPMhcWJaZOU+XuVZDYwcq3JaDhb6B7yuVUUBriPgcf2h1y3V4cdLfam+Zq2ocp qYxn55SlbDwwSk3zKQk2YHis0ZXVeZxJJzwmFbESUAULZ6XhJY+udL0KztC/7h3oAWKxJG p7DjtaLkdQqlTdTcmu/41bQzTO4XgtmxCvrqI09babnff6GOevgn9AXRGnx6Sw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cTzt84qXTz1Cmp; Sun, 21 Sep 2025 08:29:04 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Sun, 21 Sep 2025 01:29:02 -0700 From: Gleb Smirnoff To: Adrian Chadd , bz@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 785edcc2af5a - main - net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD Message-ID: References: <202509200047.58K0lcgE017026@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202509200047.58K0lcgE017026@gitrepo.freebsd.org> Hi, On Sat, Sep 20, 2025 at 12:47:38AM +0000, Adrian Chadd wrote: A> commit 785edcc2af5ae32c24f5caf5b9552f62bdae33ee A> Author: Adrian Chadd A> AuthorDate: 2025-06-10 04:22:10 +0000 A> Commit: Adrian Chadd A> CommitDate: 2025-09-20 00:42:45 +0000 A> A> net80211: convert the rest of the native net80211 drivers to SEQNO_OFFLOAD A> A> * Convert the rest of the drivers to implement driver/offloaded sequence A> number handling. A> A> * For drivers that implement their own sequence number space handling A> for A-MPDU, only call ieee80211_output_seqno_assign() if the frame A> isn't tagged with M_AMPDU_MPDU, which mirrors the original net80211 A> sequence number behaviour. (Except of course, the assignment is A> now happening during final encap/transmit, not early in encap.) A> A> Locally tested (sta mode): A> A> * ath A> * iwn A> * bwi A> * bwn A> * iwm A> * otus A> * ral A> A> Differential Revision: https://reviews.freebsd.org/D50772 A> Okayed by: bz This commit broke my iwm(4) on Thinkpad X1 Carbon 7th Gen. The symptoms are that the interface can associate and even receive DHCP address, but after that all transmitted packets are lost. Any communication attempt results in ARP requests that are not seen by other devices on the network. Reverting this commit resolves the problem. I will be able to test patches tomorrow, please send them to me. If we are not able to resolve that before start of the stabweek which is this Monday, I'd like to get this reverted from main. -- Gleb Smirnoff