From owner-svn-src-all@freebsd.org Wed Jan 13 16:59:54 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9FD2FA81C63; Wed, 13 Jan 2016 16:59:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 81421194E; Wed, 13 Jan 2016 16:59:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 126E8B945; Wed, 13 Jan 2016 11:59:53 -0500 (EST) From: John Baldwin To: Jilles Tjoelker Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r293783 - head/lib/libc/sys Date: Wed, 13 Jan 2016 08:58:12 -0800 Message-ID: <2902719.QmmqeCdr7g@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201601122053.u0CKrvmB060658@repo.freebsd.org> References: <201601122053.u0CKrvmB060658@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 13 Jan 2016 11:59:53 -0500 (EST) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 16:59:54 -0000 On Tuesday, January 12, 2016 08:53:57 PM Jilles Tjoelker wrote: > Author: jilles > Date: Tue Jan 12 20:53:57 2016 > New Revision: 293783 > URL: https://svnweb.freebsd.org/changeset/base/293783 > > Log: > Update futimens/utimensat for MFC to stable/10: > > * Fix __FreeBSD_version check. > * Update history section in man page. > > An MFC of this commit to stable/10 will allow using the new system calls > instead of the fallback. > > MFC after: 3 days Why does futimens.c exist? Given that we do not support forwards compatibility (newer libc on older kernel) only backwards compatibility (older libc on newer kernel), libc should just always call the system call directly. This is what we do for all other system calls and would avoid the issue of the earlier MFC not actually working. Allowing the unsupported 'make installkernel ; make installworld ; reboot' cycle to work across this change doesn't seem worth the effort of maintaining the osreldate checks here. -- John Baldwin