Date: Wed, 26 Dec 2018 15:36:31 +0100 From: "Julian H. Stacey" <jhs@berklix.com> To: portmgr@FreeBSD.org Cc: "Julian H. Stacey" <jhs@berklix.com> Subject: 1 line patch for ports/graphics/tiff/files/patch-tiff2ps.c Message-ID: <201812261436.wBQEaV4g006424@fire.js.berklix.net>
next in thread | raw e-mail | index | archive | help
Here is is a 1 line patch, commenting out a bad return after a perhaps aprropriate error check, http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/graphics/tiff/files/patch-tiff2ps It fixes FreeBSD current ports/graphics/tiff PORTVERSION=4.0.10 at 2018-12-26 Someone on CC please also feed it upstream to whoever is generic source maintainer beyond FreeBSD. The return is commented out to stop tiff2ps converting a usable .tiff to a useless .ps I retained warning: TIFFError(filename, "Inconsistent value of es: %d", es); which may be appropriate, but it should be just a Warning not an Error. tiff-4.0.3 on FreeBSD-9.2_RELEASE is OK. & works without error & needs no patch. Crude test: fetch http://www.berklix.eu/~jhs/src/bsd/fixes/FreeBSD/ports/gen/graphics/tiff/files/tiff2ps-testdata.tif /usr/local/bin/tiff2ps tiff2ps-testdata.tif > tiff2ps-testdata.ps My test environment: fetch http://www.berklix.eu/~jhs/src/bsd/fixes/FreeBSD/ports/gen/graphics/tiff/files/tiff2ps-testdata.jpg fetch http://www.berklix.eu/~jhs/src/bsd/fixes/FreeBSD/src/jhs/share/mk/berklix.mk fetch http://www.berklix.eu/~jhs/src/bsd/fixes/FreeBSD/src/jhs/share/mk/berklix2.mk cp berklix.mk berklix2.mk /usr/share/mk/ echo ".include <berklix.mk>" > Makefile make DEBUG_BERKLIX_MK=yes tiff2ps-testdata.pdf The various ports/ format converter utilities on FreeBSD use an assorted mis-match of defaults: USA letter V. ISO A4, so maybe some of my macros are omitting to specify A4, & eg this fails too, /usr/local/bin/tiff2ps -p -a -h11.6944 -w8.26389 but while a warning is nice, an error producing an empty dummy .ps is not nice. Cheers, Julian -- Julian Stacey, Computer Consultant Sys.Eng. BSD Linux Unix, Munich Aachen Kent First referendum stole 700,000 votes from Brits in EU; 3,700,000 globaly. Lies criminal funded; jobs pound & markets down. 1.9M new voters 1.3M dead. Email MP: "A new referendum will buy UK & EU more time (Art 50.3), to avoid a hard crash, & consider all options." http://berklix.org/brexit/#mp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812261436.wBQEaV4g006424>