From owner-freebsd-rc@FreeBSD.ORG Tue Aug 25 00:49:44 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 622BF1065695 for ; Tue, 25 Aug 2009 00:49:44 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id E79618FC14 for ; Tue, 25 Aug 2009 00:49:43 +0000 (UTC) Received: (qmail 12115 invoked by uid 399); 25 Aug 2009 00:49:40 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 25 Aug 2009 00:49:40 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4A93351E.2020107@FreeBSD.org> Date: Mon, 24 Aug 2009 17:49:34 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: d@delphij.net References: <4A7B2792.4090803@delphij.net> <4A7B487B.8060303@FreeBSD.org> <4A7F948A.2040602@delphij.net> <4A7F9EC6.9090605@FreeBSD.org> <4A7FAA42.4030607@delphij.net> <78cb3d3f0908101113s412021adk8956dd083a8fed72@mail.gmail.com> <4A806D17.9020404@delphij.net> <4A933294.8000906@delphij.net> In-Reply-To: <4A933294.8000906@delphij.net> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: [RFC] script for binding ARP <-> IP pairs X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2009 00:49:44 -0000 Xin LI wrote: > Any objections for the attached patch? I'll commit this version if > everybody is happy with it and then see if re@ would approve it for > 8.0-RELEASE. Sorry if I wasn't clear before, but all of the rc.conf variables should be prepended with static_arp_ (as opposed to just arp_). So rather than arp_args you'd want static_arp_args. I realize you're not using set_rcvar() but it's still a good idea to do that for consistency's sake, as well as to make it easier for admins to sort stuff, etc. Please make sure you change that in the man page as well. Other than that it looks fine to me. Silly question that I'm sorry just occurred to me right now, have you tested this with IPv6? :) Doug -- This .signature sanitized for your protection