From owner-freebsd-current@freebsd.org Thu Nov 21 15:19:55 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 42F871C2331 for ; Thu, 21 Nov 2019 15:19:55 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Jjsk0s3Gz4XbW; Thu, 21 Nov 2019 15:19:53 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-lj1-f174.google.com with SMTP id p18so3656658ljc.6; Thu, 21 Nov 2019 07:19:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gv1nuKSAEwdfT5Q2Fc+ZCQgJRI2fqUd1BBgBnk4YgYo=; b=tfYXVN3aaVXfCaGmQ9aG/4YtST9NT41zkYyBM6NLT4n6weeaUIMHWz/TOnuKyygeC4 i984PluDmChRUg056YBz42x3ch8thICHP3xX6bXjsvcwNM2se1pOHjYczvtlSvvhJuKo F+o6VyE7lfZ2Sy7wIQyeu94BGxEi9JL5NSn7zhSosutzczzkQvyNOlwJvBshP8baRX9z 88a/+PEFOHV4NLPqCkhsRhWkdHryoyLufPMQl77n5G3Fo3gXc17ltN7MZ4XJ1w57cJlM XEDQ39W+QYYtU6ZYr1ls6wn0h5vmrhM+HicUzusZqPB4vy68S3ja58KZnbmHxB952fkQ 5UVg== X-Gm-Message-State: APjAAAVotVYuwAxkwIty6uAq5o1aSbCC8hccBypHupEd31VvyEq/RJux sF1tCNRuurWwZEPsD+9Y8BtBAOKILQac69U15bjyOQ== X-Google-Smtp-Source: APXvYqwBpuTAwTXbtQkTWc9hJJCoqnQrYwaBzBzlUPBtB6G2Wvpk25xNJMbg8OYb4qkNLVJZHrg73mOeg65NEmupXIk= X-Received: by 2002:a2e:9d84:: with SMTP id c4mr7710684ljj.187.1574349591047; Thu, 21 Nov 2019 07:19:51 -0800 (PST) MIME-Version: 1.0 References: <0e3dd332-91d7-0aa1-43cb-43528db7c63a@nomadlogic.org> <20191121041317.GL5599@FreeBSD.org> <38318920-7d3b-ee08-b0d0-d6e04e03c6a3@nomadlogic.org> In-Reply-To: <38318920-7d3b-ee08-b0d0-d6e04e03c6a3@nomadlogic.org> From: Ed Maste Date: Thu, 21 Nov 2019 06:33:11 -0500 Message-ID: Subject: Re: breakage at usr.sbin/jail/Makefile To: Pete Wright Cc: Glen Barber , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47Jjsk0s3Gz4XbW X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-3.12 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[174.208.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.12)[ip: (-0.41), ipnet: 209.85.128.0/17(-3.17), asn: 15169(-1.97), country: US(-0.05)]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[174.208.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 15:19:55 -0000 On Wed, 20 Nov 2019 at 23:19, Pete Wright wrote: > > the issue seems to be on my amd64 system ${LINKER_TYPE} is not defined. > i was contemplating suggesting updating the .if clause in the Makefile > like so: > > .if defined($LINKER_TYPE}) && ${LINKER_TYPE} == "bfd" && ${MACHINE} == > "riscv" Yes, this is the approach I went with - Cirrus-CI started building my proposed change last night but it wasn't finished before I was. When I checked this morning it confirmed the fix works. In any case the best fix here will be to resolve the underlying RISC-V binutils issue and revert all of the workarounds. Note that FreeBSD's CI did not catch this issue because it builds with -DNO_CLEAN. I also build locally with -DNO_CLEAN and wouldn't have seen it either. In my opinion we ought to just remove the not-NO_CLEAN case from buildworld/buildkernel.