From owner-freebsd-net@FreeBSD.ORG Wed Oct 21 08:12:23 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 64F39106568F for ; Wed, 21 Oct 2009 08:12:23 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mx01.netsrc.de (mx01.netsrc.de [89.107.71.100]) by mx1.freebsd.org (Postfix) with ESMTP id 281AC8FC0A for ; Wed, 21 Oct 2009 08:12:22 +0000 (UTC) Received: from jessie.localnet (unknown [212.185.121.50]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx01.netsrc.de (Postfix) with ESMTP id 066D4192FD9; Wed, 21 Oct 2009 10:12:22 +0200 (CEST) From: Bernhard Schmidt To: freebsd-net@freebsd.org Date: Wed, 21 Oct 2009 10:12:15 +0200 User-Agent: KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.1; i686; ; ) References: <20091009170839.142800@gmx.net> <200910210833.44121.bschmidt@techwires.net> <25ff90d60910210029t5f8f67d0nd17b537ecaacdee9@mail.gmail.com> In-Reply-To: <25ff90d60910210029t5f8f67d0nd17b537ecaacdee9@mail.gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200910211012.15474.bschmidt@techwires.net> Cc: David Horn Subject: Re: Intel WiFi 5100/5300 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2009 08:12:23 -0000 On Wednesday 21 October 2009 09:29:13 David Horn wrote: > >> The only new issue I have found so far is that I must manually load > >> iwnfw.ko before loading if_iwn.ko (the module depend used to work on > >> the in-tree driver) > > > > Hmm.. that is probably related to the rename of the firmware image, > > iwnfw-5000 instead of iwnfw. Is MODULE_DEPEND(iwn, iwnfw, 1, 1, 1); an > > option there? > > MODULE_DEPEND(iwn, iwnfw_fw, 1, 1, 1) > > added to if_iwn.c fixes it nicely (note: iwnfw_fw not just iwnfw). It > turns out the original driver loaded the iwnfw.ko module as part of > firmware_get() since the firmware module name matched the first > firmware image name (see firmware.h comments). Looking at the other > drivers, the other option is to break up the firmware images into > unique kernel modules (e.g. ral or iwi), and allow firmware_get() to > do the load. I would think that this would reduce kernel memory usage > as well (several individual firmware modules vs all firmware images in > one module). Just a thought. Any "offical" opinions on that one? Should we break iwnfw up into individual modules? -- Bernhard