Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Nov 2021 21:55:53 +0100
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Emmanuel Vadot <manu@bidouilliste.com>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: b68bef1f6425 - main - x11-wm/kwinft: unbreak build after 5d998836b36f
Message-ID:  <zgqb-wx0m-wny@FreeBSD.org>
References:  <202111101058.1AAAwkpv046598@gitrepo.freebsd.org> <20211110121236.883c833d06eb1ad068c49e08@bidouilliste.com> <1r3n-hhx7-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Jan Beich <jbeich@FreeBSD.org> writes:

> Emmanuel Vadot <manu@bidouilliste.com> writes:
>
>> On Wed, 10 Nov 2021 10:58:46 GMT
>> Jan Beich <jbeich@FreeBSD.org> wrote:
>>
>>> The branch main has been updated by jbeich:
>>> 
>>> URL: https://cgit.FreeBSD.org/ports/commit/?id=b68bef1f6425117cd0d0d95626178db4c4fb3073
>>> 
>>> commit b68bef1f6425117cd0d0d95626178db4c4fb3073
>>> Author:     Jan Beich <jbeich@FreeBSD.org>
>>> AuthorDate: 2021-11-10 09:24:08 +0000
>>> Commit:     Jan Beich <jbeich@FreeBSD.org>
>>> CommitDate: 2021-11-10 10:58:09 +0000
>>> 
>>>     x11-wm/kwinft: unbreak build after 5d998836b36f
>>>     
>>>     input/filters/window_selector.cpp:19:10: fatal error: 'linux/input.h' file not found
>>>      #include <linux/input.h>
>>>               ^~~~~~~~~~~~~~~
>>>     
>>>     Pointy hat to:  manu
>>
>>  So this is my fault that you didn't list a required build dependancy
>> now ?
>
> Not so simple:
> - poudriere doesn't catch implicit build-only depenencies
> - libmtdev API isn't usable without evdev-proto
>
> $ poudriere jail -sj 122amd64
> $ jexec 122amd64-default
> $ pkg install libmtdev pkgconf
> $ cat >a.c
> #include <mtdev.h>
>
> int main()
> {
>   mtdev_new_open(0);
>   return 0;
> }
> ^D
> $ cc a.c $(pkg-config --cflags --libs mtdev)
> In file included from a.c:1:
> /usr/local/include/mtdev.h:36:10: fatal error: 'linux/input.h' file not found
> #include <linux/input.h>
>          ^~~~~~~~~~~~~~~
> 1 error generated.

Note, a similar API dependency on devel/evdev-proto exists in
devel/libevdev. 3c31f499a85f is a good example.

See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240964



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?zgqb-wx0m-wny>