From owner-freebsd-current@FreeBSD.ORG Sat Jan 12 15:42:50 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA94716A417 for ; Sat, 12 Jan 2008 15:42:50 +0000 (UTC) (envelope-from mozolevsky@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.169]) by mx1.freebsd.org (Postfix) with ESMTP id 6272013C465 for ; Sat, 12 Jan 2008 15:42:49 +0000 (UTC) (envelope-from mozolevsky@gmail.com) Received: by ug-out-1314.google.com with SMTP id y2so883184uge.37 for ; Sat, 12 Jan 2008 07:42:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=+4ynKMpFjqCaV3SNDDiLPyJA+7ObIrvaLzIgiR3K4vQ=; b=NUbRTB9wMtsdyZFxQS4CL17ubRv/ZMxft5LmCmBlrhG5ACPs6hjL6Y7ZR0xQLXQhF8RSrloLDsvrSL83+CJNNcWsVSUC4mIkn/Ew9Z0C8uOoKw/H8OwlntGlFIw7k+aF7rTAKmiVgaju8JKBbyNcscH8yWI+AoqhFIp7XFpPKWE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=UEMkTZfMniWoB/7B4lP38AvO+h63X+NjaYu06yvD5KiPU00EPpmWxHT+0sG0UYdKmaVBRdKWr06NRfeuAYpvhl6QWoImYa5/vjrJUm5y1s4i+Tp84I3a6WOrBZOwPM2b87QqOmEzajhYllqQTxpNyqtX9Toln3jPXwHt3vIKT1A= Received: by 10.67.116.18 with SMTP id t18mr1329711ugm.85.1200152568950; Sat, 12 Jan 2008 07:42:48 -0800 (PST) Received: by 10.66.248.11 with HTTP; Sat, 12 Jan 2008 07:42:48 -0800 (PST) Message-ID: Date: Sat, 12 Jan 2008 15:42:48 +0000 From: "Igor Mozolevsky" Sender: mozolevsky@gmail.com To: "Kostik Belousov" In-Reply-To: <20080112152303.GV57756@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <478556AD.6090400@bsdforen.de> <20080110003524.GB5188@soaustin.net> <200801111935.50821.peter.schuller@infidyne.com> <478887B4.9030906@bsdforen.de> <20080112152303.GV57756@deviant.kiev.zoral.com.ua> X-Google-Sender-Auth: a69406b56dcb624a Cc: Dominic Fandrey , freebsd-current@freebsd.org Subject: Re: Improving the handling of PR:s X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2008 15:42:51 -0000 On 12/01/2008, Kostik Belousov wrote: > I taken the patch, because I though that > I have such card. After the truth revealed that I am not, I preferred to > not broke support for somebody hardware. If there are other users of the > same card, why do not they complain and test the patch ? This is fairly generic and doesn't necessarily just apply to your post, but here you expect the users to be *developers*; and while most people would happily try something pre-compiled, or at least merged into the source tree (so they can just do a make xxx), significantly fewer people would be wanting to experiment patching. Firstly you expect the users, most of whom are just trying the OS out, to dig through the PR database, then to patch the necessary files, configure their system (once they figure out how to edit the relevant KERNCONF file), and so on... Seriously, what's wrong with merging various patches into the source tree and surrounding them with #ifdef WITH_EXPERIMENTAL_CODE, or WITH_EXPERIMENTAL_(module name) and then allowing that in make.conf? At least that'll take the hassle of searching through PRs/mering... Alternative (for more advanced hackers) would be to have a dedicated page that lists various experimental patches categorized by module/subsystem/etc, which allows people to pull the experimental patches directly... Another alternative is to have a boolean flag on the PR so that the author can indicate that it's a patch and have the gnats mail a separate list of uncommitted patches separately to other open PRs? Igor