From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Feb 28 12:39:23 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 07BC3D03 for ; Sat, 28 Feb 2015 12:39:23 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C8CFFF8B for ; Sat, 28 Feb 2015 12:39:22 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1SCdMFS021941 for ; Sat, 28 Feb 2015 12:39:22 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 198091] Fix devel/google-sparsehash build with clang 3.6.0 Date: Sat, 28 Feb 2015 12:39:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: dim@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: vd@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Feb 2015 12:39:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198091 Bug ID: 198091 Summary: Fix devel/google-sparsehash build with clang 3.6.0 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: vd@FreeBSD.org Reporter: dim@FreeBSD.org Assignee: vd@FreeBSD.org Flags: maintainer-feedback?(vd@FreeBSD.org) Created attachment 153611 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153611&action=edit Use swap member function instead of free swap function, to appease clang 3.6.0 During the exp-run in bug 197395, it was found that devel/google-sparsehash gives errors with clang 3.6.0: http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-27_12h37m16s/logs/errors/google-sparsehash-2.0.2_2.log The error is because clang 3.6.0 has become more strict about matching non-type template parameters. However, I am not completely sure if the construction google-sparsehash is using is legal or not, and whether clang is correct to refuse it. It looks like different versions of gcc have different opinions on the legality of non-type template parameter deduction. I will submit a bug report upstream with clang to figure that out, but in the mean time, I want to propose using the attached patch, which makes hashtable_test.cc use the swap member functions, instead of the free swap functions. --- Comment #1 from Bugzilla Automation --- Auto-assigned to maintainer vd@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.