From owner-dev-commits-ports-all@freebsd.org Thu Jun 3 10:25:08 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B96D765669D; Thu, 3 Jun 2021 10:25:08 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: from mail.evolve.de (mail.evolve.de [213.239.217.29]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.evolve.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fwhq81HHpz4n1F; Thu, 3 Jun 2021 10:25:07 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: by mail.evolve.de (OpenSMTPD) with ESMTP id cd486772; Thu, 3 Jun 2021 10:25:04 +0000 (UTC) Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id 1073f6c1 (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Thu, 3 Jun 2021 10:25:02 +0000 (UTC) Date: Thu, 3 Jun 2021 12:24:59 +0200 From: Michael Gmelin To: Mathieu Arnold Cc: Torsten Zuehlsdorff , Gerald Pfeifer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: Replacing USE_GCC=any and the danfe@ filter (was: svn commit: r568012 - head/net/tightvnc) Message-ID: <20210603122459.1af3db38@bsd64.grem.de> In-Reply-To: <20210603101157.noqag2ace5pcz6pu@aching.in.mat.cc> References: <20210603063235.676vy42y56fzvuu5@aching.in.mat.cc> <64998e65-5200-ba36-eb61-f54b26a6e2a8@toco-domains.de> <20210603101157.noqag2ace5pcz6pu@aching.in.mat.cc> X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Fwhq81HHpz4n1F X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2021 10:25:08 -0000 On Thu, 3 Jun 2021 12:11:57 +0200 Mathieu Arnold wrote: > On Thu, Jun 03, 2021 at 11:50:54AM +0200, Torsten Zuehlsdorff wrote: > > > > > > On 03.06.21 08:32, Mathieu Arnold wrote: > > > On Thu, Jun 03, 2021 at 12:22:47AM +0200, Gerald Pfeifer wrote: > > > > On Sun, 30 May 2021, Mathieu Arnold wrote: > > > > > Thank you for working on this. > > > > > > > > So, I was just ready to commit the next step and prepared a > > > > nice git style commit message: > > > > > > > > Replace USE_GCC=any with USE_GCC=yes > > > > USE_GCC=any has been equivalent to USE_GCC=yes in most > > > > cases (such as i386 and amd64 since 12.x and depending on > > > > configuration 11.x, most newer installations on other > > > > platforms, and 13.x across the board). > > > > Since commit 96c17633d90386b5bcf8 Mk/bsd.gcc.mk ... > > > > > > > > Alas, the danfe@ filter struck: > > > > > > > > remote: Resolving deltas: 100% (111/111), completed with > > > > 111 local objects. remote: > > > > remote: > > > > ================================================================ > > > > remote: First line does not start with the regular remote: > > > > category/port: subject remote: > > > > ================================================================ > > > > > > > > What now? > > > > > > > > Neither "*/*: Replace USE_GCC=any..." in the subject nor a > > > > couple dozen individual commits strike me as desirable. > > > > > > *: Replace... works just fine. > > > > This seems to be a transcription of "It works around a rule which > > has its purpose but should not be enforced 100% of the time". > > Well, no, the subject of all commits has to have a "discriminator" to > tell people scanning commits what a commit is about. > > Having '*:' or '*/*:' for commits that span many ports is also fine, > it does not defeats the rule, it acts as the discriminator saying > that it's not about a specific port, but a change, like a framework > sweep. Will cat1/port1, cat2/port2: Update to xyz still work though? If they are completely unrelated, I would assume that doing multiple commits is always preferred. But I'm thinking about ports that depend on each other, or even those using MASTERDIR, where there simply won't be a second commit. Example: devel/arcanist uses devel/arcanist-lib, so to upgrade both, only devel/arcanist-lib/* is modified. I would like to use this commit title: devel/arcanist, devel/arcanist-lib: Update to 2021-06-03 Will that pass? Thanks Michael -- Michael Gmelin