From owner-svn-src-all@freebsd.org Thu Feb 14 21:01:01 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00FDD14E18CD for ; Thu, 14 Feb 2019 21:01:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C0C38BB90 for ; Thu, 14 Feb 2019 21:01:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x844.google.com with SMTP id 2so8552259qtb.5 for ; Thu, 14 Feb 2019 13:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oZSzITwCy3GT/bRj3X3FHRVturaUaN2xL5GnOLwdDPg=; b=pTmNC7JoVjL9vejov6F6IEe/MpO6uWnzpXV7JBmvVEjfW9q7cmqAKgmwMC5Xqz5J70 Qy3UpSyW0xmlxn8B154wNdiTFP3tHuApixHjhuX3L80+532f06Pqbe8YtjSHsOn6hFy3 MoMW3dSSR0uZjkgkIkd14Zedx1LLTLSQz4NBfoiyoZ9HuVlPQriVBU9VsoSffGE3Up4q 8Lbiul/WGgqHHJoO4H5m/MgGYRTATaeR3Ah3rJbuyjDkRgyS1oSi3U1bPVX7G/mbYK27 AExM4tnbibQVReLH+8Kb9l4yoKczclZ14YsHX4BlT/SdLdPwMGp8OQglwadqmA97d1pY annA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oZSzITwCy3GT/bRj3X3FHRVturaUaN2xL5GnOLwdDPg=; b=GQBci9Z9seEZB66p0Qs75SU/geziW6HeWpdBnZZL6KzVxCSrR0cZFrfTUdKvUHG1bQ blHTRFje8sndog0AZAG51k07g7Rby5tumf1HQ6WBucInntPetENjKbuf1dgl/1O65AtT kWZcDIZu0Zm9YLWFQYPmRWZ8W751LekIRGiTbJ54XB3dcMII0BnVIHOesImkRxmV4kpZ 8pd+Gr+oDr38q2n3Z9Sgi2MxNIiCih3RAK06sGVn0RLzRpUKmX2c+EAaiPQqHfYWi0oJ nsfouYJjjh0ws1l4qgyQBNIuDAIxjdmZIMSUltMzlyMf5kRvrXBQtnlOUWWWutdDqxZH yOrA== X-Gm-Message-State: AHQUAuboTgHWk/B1NsDkV5udDPhKm1raqNseLBo6+oJO1QW6io6OJVOZ VGqKVQCuSAfYBFvRxNQxQYdRHUdp6wf/2jB2aKoncA== X-Google-Smtp-Source: AHgI3IYcLUIEyD6T65sZtv9U4Ul+sW6DUYxxXsdC/KrOscdA21aXy1e8WgbT3hNgY1+FhMpeYfx4GFqsGWdTImGUiuo= X-Received: by 2002:ac8:1806:: with SMTP id q6mr4696018qtj.242.1550178059913; Thu, 14 Feb 2019 13:00:59 -0800 (PST) MIME-Version: 1.0 References: <20190214191329.GB50900@raichu> <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> In-Reply-To: From: Warner Losh Date: Thu, 14 Feb 2019 14:00:48 -0700 Message-ID: Subject: Re: svn commit: r344129 - head To: Juli Mallett Cc: "Rodney W. Grimes" , Mark Johnston , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 8C0C38BB90 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 21:01:01 -0000 On Thu, Feb 14, 2019, 1:48 PM Juli Mallett On Thu, 14 Feb 2019 at 12:42, Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > >> > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: >> > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < >> > > > > Differential Review: https://reviews.freebsd.org/D19193 >> > > > >> > > > You sited a differential, but not give any attribution >> > > > to the external source :-( >> > > > >> > > >> > > The differential review has that information. >> > >> > External contributors should be recognized by having their names appear >> > in the commit logs. >> >> We even bother to put a special line in the commit template >> for this. Further it has been standard operating procedure >> for at least as long as I have been back that submitters >> are infact recognized in commit messages. >> > > Yeah, Phabricator must not become a second source of truth for who > actually did the work, which we had at least one case of recently. That's > no good. In this case, the difference between a patch and a bug report is > indistinguishable ("word X is misspelt at offset Y in file Z" is probably > not really Phabricator fodder at the scale of a single instance), but it > should plainly either be a Reported byline if not a Submitted one in the > commit message itself. > This is the most pointless waste of time of the year. It was a one letter typo. Yes, maybe I should have included the submitter's name, but I didn't. It doesn't deserve a long thread and a snarky response. Geeze people, get some perspective. Warner >