From owner-svn-src-head@freebsd.org Fri Jan 19 10:54:18 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF934ECFCE3; Fri, 19 Jan 2018 10:54:18 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CCE117C86D; Fri, 19 Jan 2018 10:54:16 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 5c72ff73; Fri, 19 Jan 2018 11:54:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=hPpVB/dEWbp/R55OYPoVQVVkieE=; b=oxHlkbdD1EnFE3Lyxyo1bHvtmMWi KjY50VQzDV/kvQ2qD7SH0fGg/6doXivgKpWtYwgw2knQiwhOPUv81ZSh/JWlpcFM DRBCDAocjE+nsyVUY60cdcNPFyq/SQElWS11VJ/2KDORKW8zEeSatIeowiDQg+CB 1+0J/C+xBHfQQ/s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=letvaCXAvpy/dpp2CecqLdudpnCTgxk24vK/oOrsq50q20MNkSkTIBuT suostBycaun+M7t0xMM/fk84688Gq3xg4TZ4Z0tkg/werhkcn6Apmw+6x5WHqQj5 P0ZaskhxEaMqcf//pXkk4J0SKM2umZODN6oWz8lS24dYQ6fFcgE= Received: from arcadia (evadot.gandi.net [217.70.181.36]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 58ed13a4 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Fri, 19 Jan 2018 11:54:14 +0100 (CET) Date: Fri, 19 Jan 2018 11:54:08 +0100 From: Emmanuel Vadot To: Rick Macklem Cc: Emmanuel Vadot , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r328129 - head/sys/fs/nfsserver Message-Id: <20180119115408.f333d3a6ec8d762e73f1d844@bidouilliste.com> In-Reply-To: References: <201801181528.w0IFSnWm053535@repo.freebsd.org> <20180118163855.b0a55427709c52d0ec2482c9@bidouilliste.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 10:54:19 -0000 On Thu, 18 Jan 2018 22:15:16 +0000 Rick Macklem wrote: > Emmanuel Vadot wrote: > >> Author: manu > >> Date: Thu Jan 18 15:28:49 2018 > >> New Revision: 328129 > >> URL: https://svnweb.freebsd.org/changeset/base/328129 > >> > >> Log: > >> nfs: Do not printf each time a lock structure is freed during module unload > >> > >> There can be a lot of those structures and printing a line each time we free > >> one on module unload. > > > > Finishing the sentence : > > > > There can be a lot of those structures and printing a line each time > >we free one on module unload is really time consuming, especially when > >you have a serial console plugged in. > > I will note that when I put a printf() like this in the code, it is because I > consider it an abnormal occurrence. It might be better to at least print > the message once. So should we warn once or maybe return EBUSY on unloading if there is still lock structures ? > For this case, normally all lock structures should go away when clients > unmount and unloading the nfsd module while there are active mounts > is not a safe practice. (Again NFSv4 isn't like NFSv3, there is server state > for NFSv4.) > > rick -- Emmanuel Vadot