From owner-svn-src-head@freebsd.org Thu May 26 20:19:59 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45F37B4BB9E; Thu, 26 May 2016 20:19:59 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 36E601D59; Thu, 26 May 2016 20:19:59 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id D96C01AF2; Thu, 26 May 2016 20:19:58 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Thu, 26 May 2016 20:19:57 +0000 From: Glen Barber To: "Conrad E. Meyer" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300773 - in head/sys: crypto crypto/aesni crypto/sha2 crypto/siphash kern sys Message-ID: <20160526201957.GU3335@FreeBSD.org> References: <201605261929.u4QJTTV5085421@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dw6fAZ2Gq7hkCwZ4" Content-Disposition: inline In-Reply-To: <201605261929.u4QJTTV5085421@repo.freebsd.org> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 20:19:59 -0000 --dw6fAZ2Gq7hkCwZ4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 26, 2016 at 07:29:29PM +0000, Conrad E. Meyer wrote: > Author: cem > Date: Thu May 26 19:29:29 2016 > New Revision: 300773 > URL: https://svnweb.freebsd.org/changeset/base/300773 >=20 > Log: > crypto routines: Hint minimum buffer sizes to the compiler > =20 > Use the C99 'static' keyword to hint to the compiler IVs and output dig= est > sizes. The keyword informs the compiler of the minimum valid size for = a given > array. Obviously not every pointer can be validated (i.e., the compile= r can > produce false negative but not false positive reports). > =20 > No functional change. No ABI change. > =20 >=20 This change breaks -CURRENT. --- lib/libmd__L --- md5hl.c:48:10: warning: implicit declaration of function '_libmd_MD5FileChu= nk' is invalid in C99 [-Wimplicit-function-declaration] return (MD5FileChunk(filename, buf, 0, 0)); ^ /usr/src/lib/libmd/md5.h:32:22: note: expanded from macro 'MD5FileChunk' #define MD5FileChunk _libmd_MD5FileChunk ^ Glen --dw6fAZ2Gq7hkCwZ4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXR1ptAAoJEAMUWKVHj+KTOCIP/A6fXVR8MGtkeWDyeFgOdjuD y9Uu/9EXXzqwrE5FwwTryfSNG3uUll6kZE79bjTbkMR59McSt214IU9puo11+980 1GAThTp6K6boG0sxPBFOr2rEjGd3PO3t5OS9/wrHQsSfmdNn2a2V1G/RbDeMGEq+ yVldBpD5RchlmuQb/hf6hknTZ/MOe/MT1spf1NPXZRJMAI/D76jCL9TKpHxuVc3K gdV92YUpbAFkiQeAljR35+Y6o1bCPfPk22vlPoCYda0OCTq05u1TK6fd8hM6WYdB ETy9uNhS/2TRz98fc447sa624hraAmyhfpopQ1GDwWauLoIYA9N4/Pi7p41gtIpt ilTc6dW4jBtl8B+EaOV8uUckaWwDV+lZ29JxB19OG293cVZZpFeONhrIACdxuTlE 9kuUeINPTs0X0v5/Lp2ldV+oDmagZeNMjuW1GN6MrD4I1B8Fdej3P8Fda7J1Fn4d U8d5Lwd4L4Sc0NJg5cOC4s/c0onWjLsjLMvvlEEGQqr2qU5fAAyw9Jx+0M+tyYZR V+8ag3/StByTE00oI8sVt4+eowja9SHmRVCXkDgMxMlew5Apf98jPKmWULwSJrs4 nibpVsyR4/DO2HevdmRLzIF2pnDtuTBkLsRHFRVrOSrGO81IHIIWQlSnCN+vixrF 8s9K9zYhdIEMwmLc+9e4 =rlt8 -----END PGP SIGNATURE----- --dw6fAZ2Gq7hkCwZ4--