From owner-freebsd-gnome@freebsd.org Sat Oct 29 18:43:11 2016 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FC19C26B87 for ; Sat, 29 Oct 2016 18:43:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 793CDD8E for ; Sat, 29 Oct 2016 18:43:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 75CF0C26B86; Sat, 29 Oct 2016 18:43:11 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73C53C26B85 for ; Sat, 29 Oct 2016 18:43:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 43C23D8D for ; Sat, 29 Oct 2016 18:43:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u9TIh7kF071070 for ; Sat, 29 Oct 2016 18:43:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 211201] print/freetype2: update to 2.7, add V40 code Date: Sat, 29 Oct 2016 18:43:08 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jbeich@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? exp-run? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Oct 2016 18:43:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211201 --- Comment #63 from Jan Beich (mail not working) --- (In reply to lightside from comment #56) > (In reply to comment #55) >> Can we avoid the complexity in this case? >> It'd even be 4 lines shorter. > What you proposed is the same complexity, but with static variant, which = may > require to extend number of checks (2^n - 1, where n is 2 currently) for > options, in case of more modes. It'd be better to ask upstream as gnome@ (or kwm@) are probably just as clueless whether there'd would be more options in future. I don't expect th= at due to increased maintenance compared to always compiling in the code. For = one, v40 only exist because ... If someone finds ways to make older fonts render better without introducing lists or overly complex hacks, I'm interested. https://www.freetype.org/freetype2/docs/subpixel-hinting.html >> - Don't use SED when modifying in-place >> - Make backup suffix a bit more verbose than just one confusing letter > This is not justified. > The reason to use ${SED} instead of ${REINPLACE_CMD} with different backup > extension (i.e. -i '.d.bak') is following: > -8<-- > % make -C /usr/ports/print/freetype -V REINPLACE_CMD > /usr/bin/sed -i.bak > % make -C /usr/ports/print/freetype -V SED > /usr/bin/sed > -->8- I'm arguing about semantic meaning of editing file(s) in-place: REINPLACE_C= MD carries it while SED does not. Adjusting (or removing) backup suffix is more popular via REINPLACE_CMD: $ cd /usr/ports $ git grep 'SED.* -i ' | wc -l 125 $ git grep 'REINPLACE_CMD.* -i ' | wc -l 263 Also, keeping '.bak' component the last avoids confusion with '.d' or '.deb= ug' being a non-backed up file extension. > (In reply to comment #55) >> - Use "-e" option to split commands rather than ";" to avoid tracking op= en quotes > This is just your preference, in my opinion. It also works with ";". ";" requires tracking open quotes whenever a new substitution is added inst= ead of being just one "+" line in a diff. "-e" is *probably* more popular in po= rts but I'm biased. Actually measuring usage may require a careful regexp to pa= rse newlines, (single/double) quotes, "s" command syntax. --=20 You are receiving this mail because: You are on the CC list for the bug.=