From owner-svn-src-head@freebsd.org Sat Nov 4 12:43:38 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86EBDE6DBC6 for ; Sat, 4 Nov 2017 12:43:38 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1C9326D227 for ; Sat, 4 Nov 2017 12:43:38 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x229.google.com with SMTP id z3so6193554wme.5 for ; Sat, 04 Nov 2017 05:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OGKVn9e9dz6yw9xoTnhmDvWZf0Q6f8Iw/4x+YryaYZg=; b=AycNBOgRoKa4y12stHqt4x9/+I1qo8OvUXEGTXBoRwtr4QO1fU6IKP1qLbMK1jfdR4 2TnFN926Qb5vNSrg2oR7eNIeTcyFm9t4wjFVc1kJY9j5Qk/+7AtQGRS5sfVGaNI/ZQXK 5PUVCEt5YcXSZa4KGE2XnlcqqAbs6lAr5uqxXhE+Y88RuxqUjdw/G0RkjGbPd0riUXoi T5sEO5feW4Qlv8OvS+c7XYmD8bzNfzDMZoR8oNVJes/WCrSuVq+s1xb5p2vik0uW9oNT t+ytuKGAzLlRJezPYa966baXbH6NmLim5U5+tslei+WK2/VV+LKZSiQXYY5mFKGxh/B1 Pyqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OGKVn9e9dz6yw9xoTnhmDvWZf0Q6f8Iw/4x+YryaYZg=; b=RMO58UBAkN6nwM3nJpNggQIbc9dVaFhPlGFeQrbxyC1zQD4FwuvhCiMSDXkmtGCo2d gN6uBLVWQJVOo7sahs1PiSl2HYcBRlvi90MOiN5+R3AJFYjDU4HhQP4Ke/RGDtZXlvqU QaWqRJDrIAxbNzVAqwxJm1oPCWqECO1T1Ke2bGp1GZoHRoZoxa0m31+gjyqHc22XWMnR NIiPtq+bJkxyFHjIz3+IL36IGKfQiMnjxIkB3I+Jh02mXLSehw16IuQ/dWhkuwvo93Fq o4YTAwg75Yl3ZWj6TKUoC1fio+LBTaT5SI+vKI7xSSWC72aY+cSd1P5x+bBZPlDKrXU3 /i1A== X-Gm-Message-State: AMCzsaWGfOyvMAn4vTzmG1gshhGFFZ4dw5WgTTZVQbpkK0LPbLo0m/xC n1NI6OcfHOgLHvtmDzvEPX1g8ZMlzUsZx8uFWJa3Ww== X-Google-Smtp-Source: ABhQp+QK3PgoaFJ4OXl+Rj80T4cwWfBwlgP9Qg0fQeH16oLl725PC2EfMrEh9wLttKEg3eVwNu1bu1lYsh7qlBqD7WI= X-Received: by 10.80.134.47 with SMTP id o44mr12796938edo.306.1509799416496; Sat, 04 Nov 2017 05:43:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.135.21 with HTTP; Sat, 4 Nov 2017 05:43:36 -0700 (PDT) In-Reply-To: <30042B831BE3AF428BC874A8B81B08E989BFC9ED@MX104CL02.corp.emc.com> References: <30042B831BE3AF428BC874A8B81B08E989BFC9ED@MX104CL02.corp.emc.com> From: Oliver Pinter Date: Sat, 4 Nov 2017 13:43:36 +0100 Message-ID: Subject: Re: svn commit: r325285 - head/sys/amd64/amd64 To: "Morris, Don" Cc: "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2017 12:43:38 -0000 On 11/3/17, Morris, Don wrote: >> Modified: head/sys/amd64/amd64/pmap.c >> ============================================================================== >> --- head/sys/amd64/amd64/pmap.c Wed Nov 1 16:32:11 2017 (r325284) >> +++ head/sys/amd64/amd64/pmap.c Wed Nov 1 18:06:44 2017 (r325285) >> @@ -2892,8 +2892,8 @@ reclaim_pv_chunk_leave_pmap(pmap_t pmap, pmap_t >> locked > > static vm_page_t > > reclaim_pv_chunk(pmap_t locked_pmap, struct rwlock **lockp) > > { >> - struct pv_chunk *pc, *pc_marker; >> - struct pv_chunk_header pc_marker_b; >> + struct pv_chunk *pc, *pc_marker, *pc_marker_end; >> + struct pv_chunk_header pc_marker_b, pc_marker_end_b; >> struct md_page *pvh; >> pd_entry_t *pde; >> pmap_t next_pmap, pmap; >> @@ -2906,6 +2906,7 @@ reclaim_pv_chunk(pmap_t locked_pmap, struct rwlock >> **l >> uint64_t inuse; >> int bit, field, freed; >> bool start_di; >> + static int active_reclaims = 0; >> >> PMAP_LOCK_ASSERT(locked_pmap, MA_OWNED); >> KASSERT(lockp != NULL, ("reclaim_pv_chunk: lockp is NULL")); >> @@ -2914,7 +2915,9 @@ reclaim_pv_chunk(pmap_t locked_pmap, struct rwlock >> **l >> PG_G = PG_A = PG_M = PG_RW = 0; >> SLIST_INIT(&free); >> bzero(&pc_marker_b, sizeof(pc_marker_b)); >> + bzero(&pc_marker_end, sizeof(pc_marker_end)); >> pc_marker = (struct pv_chunk *)&pc_marker_b; >> + pc_marker_end = (struct pv_chunk *)&pc_marker_end_b; > > Shouldn't the additional bzero here be of pc_marker_end_b, not > pc_marker_end? Minor bug -- but just saying... Sure, sizeof(pointer) returns 8 (on amd64) instead of sizeof(struct). > > Don Morris > (Statements are not those of my employer, etc, etc...) > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >