From owner-p4-projects@FreeBSD.ORG  Sat Oct  7 04:39:43 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9B75316A40F; Sat,  7 Oct 2006 04:39:43 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3BA6616A403
	for <perforce@freebsd.org>; Sat,  7 Oct 2006 04:39:43 +0000 (UTC)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0A2C443D45
	for <perforce@freebsd.org>; Sat,  7 Oct 2006 04:39:43 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k974dgR2002427
	for <perforce@freebsd.org>; Sat, 7 Oct 2006 04:39:42 GMT
	(envelope-from imp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k974dgnr002418
	for perforce@freebsd.org; Sat, 7 Oct 2006 04:39:42 GMT
	(envelope-from imp@freebsd.org)
Date: Sat, 7 Oct 2006 04:39:42 GMT
Message-Id: <200610070439.k974dgnr002418@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	imp@freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 107394 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Oct 2006 04:39:43 -0000

http://perforce.freebsd.org/chv.cgi?CH=107394

Change 107394 by imp@imp_lighthouse on 2006/10/07 04:38:56

	Wow.  That's a common bug.  Check irq_res when allocating an
	interrupt.

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/at91_ssc.c#9 edit
.. //depot/projects/arm/src/sys/arm/at91/at91_twi.c#25 edit
.. //depot/projects/arm/src/sys/arm/at91/if_ate.c#56 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/at91_ssc.c#9 (text+ko) ====

@@ -176,7 +176,7 @@
 	rid = 0;
 	sc->irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ, &rid,
 	    RF_ACTIVE);
-	if (sc->mem_res == NULL)
+	if (sc->irq_res == NULL)
 		goto errout;
 	return (0);
 errout:

==== //depot/projects/arm/src/sys/arm/at91/at91_twi.c#25 (text+ko) ====

@@ -173,7 +173,7 @@
 	rid = 0;
 	sc->irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ, &rid,
 	    RF_ACTIVE);
-	if (sc->mem_res == NULL)
+	if (sc->irq_res == NULL)
 		goto errout;
 	return (0);
 errout:

==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#56 (text+ko) ====

@@ -333,7 +333,7 @@
 	rid = 0;
 	sc->irq_res = bus_alloc_resource_any(dev, SYS_RES_IRQ, &rid,
 	    RF_ACTIVE);
-	if (sc->mem_res == NULL)
+	if (sc->irq_res == NULL)
 		goto errout;
 
 	/*