From nobody Sat Mar 19 19:54:04 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9DEE71A29E65; Sat, 19 Mar 2022 19:54:15 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KLWmQ6LGBz3JNQ; Sat, 19 Mar 2022 19:54:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-ot1-x32e.google.com with SMTP id k25-20020a056830151900b005b25d8588dbso7910556otp.4; Sat, 19 Mar 2022 12:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wE+w6reyzd2hJ4ektXb5mMq8WOg9tECrNSrha4s+Xvs=; b=RdGmvl2LCfIXCSi7dnzLv7GMoE6exHARKj3fEZeN5TsAlDn6N1CuxMfglNXl/LOHP0 M40LigYhlkugGxCslKqlJdocQ12pZzGsuRMPcqqcf8MZPo+/C4VSv+QvCczkvDP328qx DSFgA3J0s3URy/swyT2qIl7yDYvu+hDw8IOp+7RK9cesGYET24I2KD9K52YoQDnIXkro dLBaFxbAPHWEicbua+t3UNvb4Vkj2z0l4XeX0fgQQTT/8HYzVlbX64kUu7sE8fa510Uw pYWvWJ0BhBBseOkY5eGorNjNUqEufIe/kNUulPQkpfj+2ku5KguVQqaFQAiY6Q9o1lZH 8zHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=wE+w6reyzd2hJ4ektXb5mMq8WOg9tECrNSrha4s+Xvs=; b=5YvfzUHE9VAIiPnI/B+pVACyjMPSBxGcc+L2GO86yb/qkfmR//s+TjHIzzOGwXtNtW DhFDXntGH14jhmdpDeEfj4T+qZqFx+u1W2bzeNlJPdu6cgHGBhkV3PGvLGrBQ9PLdScN jD0aQq810cWTYyI9c7gGam/q/rc87OmK/Wp/exDIGPxbsjXEZ+Oc3+Eb0nl626ngIDek 7QrUHehdos9IsVZOkShMhRpat0NKAUGDB8T/iJCkqMlDZkchVNU7CZLM9vYSnbz47Hcf +pVuDZOPfqF4pOJz8ecMHgcSSIc5V5Ly2xNfTeaS2XpsyhPPQ21n3RUHgTFXO/QvZSC/ KceQ== X-Gm-Message-State: AOAM533IypCTHc0n1i7LUqanjRskbmxek3UIZ4DZQH+UmqgixThRYADE ryG+P5iEtttWb5WKBOc9xeXQ/YOstzBWFg== X-Google-Smtp-Source: ABdhPJxotOx2srPLWnS5HFZb7gEpCXJBSMB7amru+5Y//giQH3hKPjUlck6V6KJ1uVxk9jfD6r6ogg== X-Received: by 2002:a05:6830:4121:b0:5c9:4d2b:7364 with SMTP id w33-20020a056830412100b005c94d2b7364mr5647938ott.366.1647719648057; Sat, 19 Mar 2022 12:54:08 -0700 (PDT) Received: from framework ([200.68.139.38]) by smtp.gmail.com with ESMTPSA id c8-20020a4ad788000000b0031ce69b1640sm5002002oou.10.2022.03.19.12.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Mar 2022 12:54:07 -0700 (PDT) Date: Sat, 19 Mar 2022 15:54:04 -0400 From: Mark Johnston To: Mark Millard Cc: Thomas Zander , freebsd-ports@freebsd.org, FreeBSD-STABLE Mailing List Subject: Re: git: 43741377b143 - main - security/openssl: Security update to 1.1.1n Message-ID: References: <2E632408-4D4E-426C-8DC7-A1024A1D328D.ref@yahoo.com> <2E632408-4D4E-426C-8DC7-A1024A1D328D@yahoo.com> List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4KLWmQ6LGBz3JNQ X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=RdGmvl2L; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::32e as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [1.63 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; FREEMAIL_TO(0.00)[yahoo.com]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[200.68.139.38:received]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_SPAM_SHORT(0.97)[0.970]; NEURAL_HAM_LONG(-0.63)[-0.629]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_SPAM_MEDIUM(0.98)[0.985]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::32e:from]; MLMMJ_DEST(0.00)[freebsd-ports,freebsd-stable]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sat, Mar 19, 2022 at 12:00:20PM -0700, Mark Millard wrote: > On 2022-Mar-19, at 11:07, Thomas Zander wrote: > > > On Sat, 19 Mar 2022 at 18:32, Mark Millard wrote: > >> May be report to Mark J. how to run the same test builds > >> that failed for -p8 but worked for -p7? > > > > Sure, good point. > > A build that reliably causes broken packages on p8 but not on p7 for > > me is running: > > > > poudriere testport -o multimedia/mplayer -j <13.0-amd64-jail here> > > > > This caused the broken png and python packages when they were built as > > dependencies. > > In poudriere.conf I set this: > > DISTFILES_CACHE=/vcache/distfiles > > CCACHE_DIR=/vcache/ccache > > ALLOW_MAKE_JOBS=yes > > > > The ALLOW_MAKE_JOBS should increase the number of parallel IO > > operations in-flight on the pool, maybe this increases the likelihood > > of triggering the issue? > > The DISTFILES_CACHE and CCACHE_DIR are in the same zfs pool as > > /poudriere, not sure if this is relevant. > > The zfs pool is a single disk, no raid, mirror or anything fancy. > > On a ThreadRipper 1950X, PCIe Optane storage, 128 GiBytes of > RAM, I've used bectl to boot the 13.0_RELEASE-p8 environment > and have started: > > poudriere testport -o multimedia/mplayer -j13_0R-amd64-bulk_a > > where the jail had nothing built in it at the start. So: > > [00:00:08] Building 271 packages using up to 32 builders > > The primary difference is that I've never used ccache and > did not try to do so here. The "zfs pool is a single disk, > no raid, mirror or anything fancy" is accurate, as is the > use of ALLOW_MAKE_JOBS= . > > That did not take long . . . > > It proves that ccache is not required. Also some files > seem to get only small blocks of zero-bytes, others > large ones. But I've not checked for the null characters > being at the end instead of earlier in the file. I still am not able to reproduce it. I think it's indeed a concurrency problem, and I found a possible culprit. Mark or Thomas, if you're able to build a new kernel from the releng/13.0 branch and test it, could you please try this patch? diff --git a/sys/contrib/openzfs/module/zfs/dnode.c b/sys/contrib/openzfs/module/zfs/dnode.c index 8592c5f8c3a9..b69ba68ec780 100644 --- a/sys/contrib/openzfs/module/zfs/dnode.c +++ b/sys/contrib/openzfs/module/zfs/dnode.c @@ -1661,7 +1661,7 @@ dnode_is_dirty(dnode_t *dn) mutex_enter(&dn->dn_mtx); for (int i = 0; i < TXG_SIZE; i++) { - if (list_head(&dn->dn_dirty_records[i]) != NULL) { + if (multilist_link_active(&dn->dn_dirty_link[i])) { mutex_exit(&dn->dn_mtx); return (B_TRUE); }