From owner-p4-projects@FreeBSD.ORG  Thu Aug 21 21:32:03 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1A28B1065685; Thu, 21 Aug 2008 21:32:03 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D1E841065683
	for <perforce@FreeBSD.org>; Thu, 21 Aug 2008 21:32:02 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id BE1388FC14
	for <perforce@FreeBSD.org>; Thu, 21 Aug 2008 21:32:02 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7LLW2iZ023539
	for <perforce@FreeBSD.org>; Thu, 21 Aug 2008 21:32:02 GMT
	(envelope-from ed@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7LLW2B7023537
	for perforce@freebsd.org; Thu, 21 Aug 2008 21:32:02 GMT
	(envelope-from ed@FreeBSD.org)
Date: Thu, 21 Aug 2008 21:32:02 GMT
Message-Id: <200808212132.m7LLW2B7023537@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	ed@FreeBSD.org using -f
From: Ed Schouten <ed@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 148049 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Aug 2008 21:32:03 -0000

http://perforce.freebsd.org/chv.cgi?CH=148049

Change 148049 by ed@ed_flippo on 2008/08/21 21:31:23

	D'oh! Don't forget to check the return value of
	ttyhook_register() in SNPSTTY.

Affected files ...

.. //depot/projects/mpsafetty/sys/dev/snp/snp.c#9 edit

Differences ...

==== //depot/projects/mpsafetty/sys/dev/snp/snp.c#9 (text+ko) ====

@@ -243,6 +243,8 @@
 		error = ttyhook_register(&ss->snp_tty, td, *(int *)data,
 		    &snp_hook, ss);
 		sx_xunlock(&snp_register_lock);
+		if (error != 0)
+			return (error);
 
 		/* Now that went okay, allocate a buffer for the queue. */
 		tp = ss->snp_tty;
@@ -250,7 +252,7 @@
 		ttyoutq_setsize(&ss->snp_outq, tp, SNP_OUTPUT_BUFSIZE);
 		tty_unlock(tp);
 
-		return (error);
+		return (0);
 	case SNPGTTY:
 		/* Obtain device number of associated TTY. */
 		if (ss->snp_tty == NULL)