From owner-cvs-all Sat Sep 1 14:29: 3 2001 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [216.33.66.196]) by hub.freebsd.org (Postfix) with ESMTP id 6382837B408; Sat, 1 Sep 2001 14:28:58 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id 2744581D01; Sat, 1 Sep 2001 16:28:53 -0500 (CDT) Date: Sat, 1 Sep 2001 16:28:53 -0500 From: Alfred Perlstein To: Julian Elischer Cc: Matt Dillon , Peter Wemm , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern subr_prof.c kern_ntptime.c kern_xxx.c Message-ID: <20010901162853.A81307@elvis.mu.org> References: <20010901074325.28AE13807@overcee.netplex.com.au> <200109010827.f818RW370778@earth.backplane.com> <20010901135013.Y81307@elvis.mu.org> <3B914D42.478B3FE@elischer.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3B914D42.478B3FE@elischer.org>; from julian@elischer.org on Sat, Sep 01, 2001 at 02:04:02PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Julian Elischer [010901 16:12] wrote: > Alfred Perlstein wrote: > > > > * Matt Dillon [010901 03:27] wrote: > > > > > > Also, since I'm in critique mode... for gods sake, LAY OFF THE > > > MULTI-LINE MACROS AND INLINES FOR COMMON PROCEDURE CALLS!! The bloat > > > they are causing is unbelievable. > > > > Agreed, those are really bad. > > > Which ones are you refering to? I was making a general statement that heavily used macros that expand (especially into mtx_lock()) are particularly painful in regards to bloat and busting icache. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message