From owner-svn-src-head@FreeBSD.ORG  Mon Sep  3 09:21:55 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E8692106566B;
	Mon,  3 Sep 2012 09:21:55 +0000 (UTC) (envelope-from ray@freebsd.org)
Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146])
	by mx1.freebsd.org (Postfix) with ESMTP id 900DC8FC19;
	Mon,  3 Sep 2012 09:21:55 +0000 (UTC)
Received: from terran.dlink.ua (unknown [192.168.10.90])
	by smtp.dlink.ua (Postfix) with SMTP id 705EDC4935;
	Mon,  3 Sep 2012 12:21:54 +0300 (EEST)
Date: Mon, 3 Sep 2012 12:23:52 +0300
From: Aleksandr Rybalko <ray@freebsd.org>
To: Garrett Cooper <yanegomi@gmail.com>
Message-Id: <20120903122352.951b4253.ray@freebsd.org>
In-Reply-To: <A8FC4639-8B1E-4858-A5E8-33D5A4CBA7CF@gmail.com>
References: <201209030852.q838q6lC053405@svn.freebsd.org>
	<A8FC4639-8B1E-4858-A5E8-33D5A4CBA7CF@gmail.com>
Organization: FreeBSD Project
X-Mailer: Sylpheed 2.7.1 (GTK+ 2.20.1; i386-portbld-freebsd8.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, Aleksandr Rybalko <ray@FreeBSD.org>,
	src-committers@freebsd.org, svn-src-all@freebsd.org
Subject: Re: svn commit: r240067 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Sep 2012 09:21:56 -0000

On Mon, 3 Sep 2012 02:05:15 -0700
Garrett Cooper <yanegomi@gmail.com> wrote:

>> On Sep 3, 2012, at 1:52 AM, Aleksandr Rybalko wrote:
>> 
>> > Author: ray
>> > Date: Mon Sep  3 08:52:05 2012
>> > New Revision: 240067
>> > URL: http://svn.freebsd.org/changeset/base/240067
>> > 
>> > Log:
>> >  Add kern.hintmode sysctl variable to show current state of hints:
>> >  0 - loader hints in environment only;
>> >  1 - static hints only
>> >  2 - fallback mode (Dynamic KENV with fallback to kernel
>> > environment) Add kern.hintmode write handler, accept only value 2.
>> > That will switch static KENV to dynamic. So it will be possible to
>> > change device hints.
>> 
>> ...
>> 
>> > +	/* Migrate from static to dynamic hints */
>> > +	switch (hintmode) {
>> > +	case 0:
>> > +		if (dynamic_kenv)
>> > +			/* Already here */
>> > +			hintmode = value; /* XXX: Need we switch
>> > or not ? */
>> > +			return (0);
>> 
>> ^^^^ typo (missing braces)? ^^^^

Ohhh, yeah, testing now.
Thank you!

>> 
>> Also, don't you need extra glue for jails?

Why, jails uses separate hints/kenv?

>> 
>> -Garrett

Thanks.
-- 
Aleksandr Rybalko <ray@freebsd.org>