From owner-freebsd-commit Fri Jun 9 11:10:48 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA22295 for commit-outgoing; Fri, 9 Jun 1995 11:10:48 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA21330 for cvs-sys-outgoing; Fri, 9 Jun 1995 11:07:42 -0700 Received: (from davidg@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id LAA21171 ; Fri, 9 Jun 1995 11:06:55 -0700 Date: Fri, 9 Jun 1995 11:06:55 -0700 From: David Greenman Message-Id: <199506091806.LAA21171@freefall.cdrom.com> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/pci aic7870.c Sender: commit-owner@FreeBSD.org Precedence: bulk davidg 95/06/09 11:06:55 Modified: sys/i386/scsi aic7xxx.c sys/pci aic7870.c Log: 1) SCSI_RESID_VALID was not getting set in xs->flags so even though the aic7xxx driver was doing the right thing, it was getting ignored by the upper level scsi code. This may affect tape drives, so I consider this a critical fix. 2) xs->status was not set to zero during the initialization of a command. Although I don't think this should be the client's (ie the driver's) responsibility, it seems that it currently is, so it needs to be cleared. Without this change, the upper level scsi code will attempt to interpret the sense information on every command complete (since xs->status is usually left at 2, "check sense"). This gives a slight performance increase, as well as stops fooling /sbin/scsi into thinking there was an error on the command. 3) Document that we support the aic7850 controllers in the aic7870.c header. Aic7870.c should probably become aic78xx.c sometime down the road. Submitted by: Justin Gibbs