From owner-svn-ports-head@freebsd.org Wed Feb 10 02:35:01 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 897385367EC; Wed, 10 Feb 2021 02:35:01 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Db3ks3T0Mz4mNf; Wed, 10 Feb 2021 02:35:01 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612924501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7+BAEidd3oZlzIgXytQhRzq9R84gBOODWt18fx6iUnw=; b=lrtnlJfr5O6uK8BreWcb9vKmR7Bfp4YUJYllxGopi7tE08WjvBUaORIuK4scBgeHQ25NMI 6iXPP8hzP5fw5iqHXcyV0tFKulj2HwZ3qrmdh/WNXfNLr07ObTBBvn7pVAPyPl9a5Ebrmi M9xOiVbRNyKoXDx3nDIrZ8GujcS/ggi5Zjwty4EdBueFxqDiQapGi9pVC+7NrZxiOf3z7C O9/BwM19B1ZcaDLO13zLpdFgigpTDJ8erTfhIZMVN265o6GYM7+YUsFHyPduIAiVU/JM4j DC2Vxg2Ek0XqfY6dWD7pkD4uZKSsGWJIw23RyAdzISSCg6bCDMmDYqupbuHTHQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 60D563CA5; Wed, 10 Feb 2021 02:35:01 +0000 (UTC) Date: Wed, 10 Feb 2021 02:35:01 +0000 From: Alexey Dokuchaev To: Joseph Mingrone Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r564803 - in head/sysutils: . rmlint rmlint/files Message-ID: <20210210023501.GA65146@FreeBSD.org> References: <202102091926.119JQQL8050604@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202102091926.119JQQL8050604@repo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612924501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7+BAEidd3oZlzIgXytQhRzq9R84gBOODWt18fx6iUnw=; b=skYVUj18ZYdwHUiMtUYq1j79M2pJASXSmM82GKEm73Df8dKUpUSKgXdgsFMsch+vGZcMZg VjWHiLIeG32gdr0FIRyAYf/L5JS133QAOSgwDAykq0kODZcgTQM8naFwre9OYxjL8jXOzi FOGuhBrvKk/mejsWPyadR5a5owIfaSHrMGoKnqARgqDl/jkaliFQqcRxVgMY3ZDx/9Ty9Z W1VQYbH7rO4Yt2VM+wkqsupXGP+SKZq68+qJZVGImauhJRGcdLSz3J7WCijgGYcjfWwTHf LM6wMantG6LLLDYGLQDGjROZXM0esQrQSYpZ5xQXfs2pOEYLngNXz00qon+aQQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1612924501; a=rsa-sha256; cv=none; b=QzktNKi3kNxM37pmR9HrD7g34rzjsdkoLd9ERy48Jv1U0MoD5HHIpHpWv2xl6rGtdDL1lk 7exg5ZrBJHnPnKKMWoOwcmXLZaYXGhhYFc+SJiamEAsZVr6Mb7yMzjq39yy2x+hn+O2ORl PlBzSKVu4J9FYXFRvAVbg8NFuI0jInyFQ7GS95ZrNLmTRxzQN1mlshrNAFkemzOzJyvpIq dpLD85V55oVLDN15r979CV4nGSulUubR9tsOLIk4iC82gRFQdkyxvmZ/dAIesRCtKXx5+n l6iq15TDqpy8F51WXrzCjoK1VPXmC7L9mPd7wgscRGco+QgeuU6H4z+gLWQIwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 02:35:01 -0000 On Tue, Feb 09, 2021 at 07:26:26PM +0000, Joseph Mingrone wrote: > New Revision: 564803 > URL: https://svnweb.freebsd.org/changeset/ports/564803 > > Log: > New port, sysutils/rmlint: Remove duplicates from your filesystem Hi Joseph, I'm afraid this was not sufficiently reviewed, there are number of issues with this port, I'll comment on the more serious ones. > ... > +BUILD_DEPENDS= ${LOCALBASE}/lib/libglib-2.0.so:devel/glib20 \ This line looks quite weird, especially given USE_GNOME=glib20 below. What exactly it's supposed to achieve? > + gettext:devel/gettext \ > + pkgconf:devel/pkgconf \ We have USES for these. > +USES= gnome python scons If build, run, and test arguments for "python" are omitted, it will be added as BUILD_DEPENDS, RUN_DEPENDS and TEST_DEPENDS, now let's see: scons already implies python:build, and the program is written in C. It does uses Python for optional GUI, but it's explicitly disabled with --without-gui passed on the MAKE_ARGS. I didn't look if there are any tests which require it, but given the amount of mistakes with this port, it's probably also wrong. > +USE_GITHUB= yes > +GH_ACCOUNT= sahib > +GH_PROJECT= rmlint This is the default as it matches the port name. > +OPTIONS_DEFINE= NLS > + > +NLS_USES= gettext-runtime > +NLS_CONFIGURE_WITH= gettext If gettext is optional, why was it put on global BUILD_DEPENDS earlier? > +@@ -316,6 +316,8 @@ int rm_xattr_clear_hash(RmFile *file, RmSession *sessi > + > + #if HAVE_XATTR > + > ++#if HAVE_XATTR > ++ Two consecutive "#if HAVE_XATTR" lines look strange. Could the existing one be used? > +++ head/sysutils/rmlint/pkg-descr > @@ -0,0 +1,5 @@ > +rmlint is an "extremely fast tool to remove duplicates and other lint > +from your filesystem." This description essentially repeats the COMMENT and thus is not really helpful. The one provided on the website is longer and better (starts with "rmlint finds space waste and other broken things on your filesystem and offers to remove it. It is able to find: ..." > + > +WWW: https://rmlint.rtfd.org/ One WWW line is enough (see PHB Section 3.2.1). Also, we typically would chase HTTP redirects (302 in this case). > +WWW: https://github.com/sahib/rmlint ./danfe